-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move runner and export it #539
Conversation
plugin/runner/runner.go
Outdated
"github.com/ava-labs/subnet-evm/plugin/evm" | ||
) | ||
|
||
func Run() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add a string argument so the external repo can add some text to the PrintVersion message?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed it would be nice to allow an external repo to optionally specify some additional output to be included in PrintVersion()
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Adding the DO NOT MERGE label as @ceyonur and I talked offline that we want to spend a little more time thinking about the best way to do this before putting out an example that we would expect the community to start using. |
move runner and export it (ava-labs#539)
Why this should be merged
Makes it possible for external programs to import the main runner function from subnet-evm like
in another repo's
plugin/main.go
:How this works
moves main function to a separate exported package
How this was tested
Locally tested
How is this documented
Will add a new repo for example and document it.