Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precompile improvements merge #513

Merged
merged 28 commits into from
Feb 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
bec556f
Light client mode to unlock dynamic state sync (#424)
darioush Jan 10, 2023
91f5897
Fix: typos (#428)
omahs Jan 10, 2023
197add9
Bump to v0.4.8 and bump AvalancheGo dependency to v1.9.6 (#429)
aaronbuchwald Jan 11, 2023
880ec77
Add requirement that Subnet-evm upgrade is enabled at genesis (#419)
anusha-ctrl Jan 13, 2023
adb9529
Add release checklist template (#435)
aaronbuchwald Jan 23, 2023
0a2e17e
Bump avalanchego dep to v1.9.7 and start v0.4.9 release cycle (#433)
aaronbuchwald Jan 23, 2023
dbc1b4d
Coreth 0.11.6 sync (#436)
ceyonur Jan 23, 2023
a584fca
Refactor e2e tests (#425)
aaronbuchwald Jan 26, 2023
13d49a7
Improve version output (#463)
aaronbuchwald Jan 28, 2023
d1cbe9d
nil timestamp in genesis should be upgradeable (#461)
darioush Jan 28, 2023
76e3fe2
release locks on return (#470)
darioush Jan 30, 2023
954fe72
- Adding missing import "encoding/json" (used in Stringer-method) (#465)
itinance Jan 31, 2023
01a16a0
fix allow list comments (#469)
ceyonur Jan 31, 2023
009c86f
add nil checks (#473)
ceyonur Feb 1, 2023
1955873
Warp backend interface and implementation (#452)
Feb 1, 2023
5dfa34f
Add documentation section to PR template (#484)
aaronbuchwald Feb 3, 2023
7aa90d0
remove current rules (#481)
ceyonur Feb 5, 2023
7887607
add documentation guidelines (#486)
darioush Feb 6, 2023
c667f95
parseInt from ENV var (#491)
ceyonur Feb 6, 2023
50da2fd
Add generate precompile script to fix CGO flags issue (#489)
aaronbuchwald Feb 6, 2023
fe5e55c
try to fix lint job (#499)
darioush Feb 8, 2023
40c5212
build with avago v1.9.8 (#498)
cam-schultz Feb 8, 2023
0731a82
Signature Request Handler (#459)
Feb 9, 2023
8343e42
Update codeowners (#492)
aaronbuchwald Feb 9, 2023
38ad7f5
Get signature endpoint: alternative PR with different packaging (#507)
darioush Feb 10, 2023
75a5709
Merge branch 'master' into precompile-improvements-main
aaronbuchwald Feb 16, 2023
4ee9802
Fix regression test added prior to merge
aaronbuchwald Feb 16, 2023
93d274f
Fix fee manager invalid fee config test
aaronbuchwald Feb 16, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,10 @@

# review whenever someone opens a pull request.

* @ceyonur @darioush @patrick-ogrady @aaronbuchwald
* @ceyonur @darioush @aaronbuchwald

# These owners will be the owner of the contract-examples sub-directory.

contract-examples/ @dasconnor @anusha-ctrl

# These owners will be the owner of the scripts sub-directory.
# Specific directories:

peer/ @anusha-ctrl
contract-examples/ @anusha-ctrl
scripts/ @anusha-ctrl
52 changes: 31 additions & 21 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,35 +1,45 @@
# Contributing

Thank you for considering to help out with the source code! We welcome
contributions from anyone on the internet, and are grateful for even the
Thank you for considering to help out with the source code! We welcome
contributions from anyone on the internet, and are grateful for even the
smallest of fixes!

If you'd like to contribute to coreth, please fork, fix, commit and send a
If you'd like to contribute to subnet-evm, please fork, fix, commit and send a
pull request for the maintainers to review and merge into the main code base. If
you wish to submit more complex changes though, please check up with the core
devs first on [Discord](https://chat.avalabs.org) to
ensure those changes are in line with the general philosophy of the project
you wish to submit more complex changes though, please check up with the core
devs first on [Discord](https://chat.avalabs.org) to
ensure those changes are in line with the general philosophy of the project
and/or get some early feedback which can make both your efforts much lighter as
well as our review and merge procedures quick and simple.

## Coding guidelines

Please make sure your contributions adhere to our coding guidelines:

* Code must adhere to the official Go
[formatting](https://golang.org/doc/effective_go.html#formatting) guidelines
(i.e. uses [gofmt](https://golang.org/cmd/gofmt/)).
* Code must be documented adhering to the official Go
[commentary](https://golang.org/doc/effective_go.html#commentary) guidelines.
* Pull requests need to be based on and opened against the `master` branch.
* Pull reuqests should include a detailed description
* Commits are required to be signed. See [here](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits)
for information on signing commits.
* Commit messages should be prefixed with the package(s) they modify.
* E.g. "eth, rpc: make trace configs optional"
Please make sure your contributions adhere to our coding and documentation
guidelines:

- Code must adhere to the official Go
[formatting](https://golang.org/doc/effective_go.html#formatting) guidelines
(i.e. uses [gofmt](https://golang.org/cmd/gofmt/)).
- Pull requests need to be based on and opened against the `master` branch.
- Pull reuqests should include a detailed description
- Commits are required to be signed. See [here](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits)
for information on signing commits.
- Commit messages should be prefixed with the package(s) they modify.
- E.g. "eth, rpc: make trace configs optional"

## Documentation guidelines

- Code should be well commented, so it is easier to read and maintain.
Any complex sections or invariants should be documented explicitly.
- Code must be documented adhering to the official Go
[commentary](https://golang.org/doc/effective_go.html#commentary) guidelines.
- Changes with user facing impact (e.g., addition or modification of flags and
options) should be accompanied by a link to a pull request to the [avalanche-docs](https://github.com/ava-labs/avalanche-docs)
repository. [example](https://github.com/ava-labs/avalanche-docs/pull/1119/files).
- Changes that modify a package significantly or add new features should
either update the existing or include a new `README.md` file in that package.

## Can I have feature X

Before you submit a feature request, please check and make sure that it isn't
Before you submit a feature request, please check and make sure that it isn't
possible through some other means.

25 changes: 25 additions & 0 deletions .github/ISSUE_TEMPLATE/release_checklist.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
---
name: Release Checklist
about: Create a ticket to track a release
title: ''
labels: release
assignees: ''

---

**Release**
The release version and a description of the planned changes to be included in the release.

**Issues**
Link the major issues planned to be included in the release.

**Documentation**
Link the relevant documentation PRs for this release.

**Checklist**
- [ ] Update version in scripts/versions.sh and plugin/evm/version.go
- [ ] Bump AvalancheGo dependency for RPCChainVM Compatibility
- [ ] Add new entry in compatibility.json for RPCChainVM Compatibility
- [ ] Update AvalancheGo compatibility in README
- [ ] Bump cmd/simulator go mod (if needed)
- [ ] Confirm goreleaser job has successfully generated binaries by checking the releases page
2 changes: 2 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,5 @@
## How this works

## How this was tested

## How is this documented
28 changes: 7 additions & 21 deletions .github/workflows/lint-tests-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ on:
jobs:
lint_test:
name: Lint
runs-on: ubuntu-18.04
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v3
- run: ./scripts/lint_allowed_geth_imports.sh
Expand Down Expand Up @@ -63,29 +63,15 @@ jobs:
- name: Yarn install
run: yarn
working-directory: ./contract-examples
- name: Run e2e tests
- name: Install AvalancheGo Release
shell: bash
run: SKIP_NETWORK_RUNNER_START=true SKIP_NETWORK_RUNNER_SHUTDOWN=true ENABLE_SOLIDITY_TESTS=true scripts/run.sh

simulator_test:
name: Load testing with simulator
runs-on: ubuntu-latest
steps:
- name: Git checkout
uses: actions/checkout@v3
with:
fetch-depth: 0
- name: Set up Go
uses: actions/setup-go@v3
with:
go-version: 1.18
- name: Install dependencies with go module
run: BASEDIR=/tmp/e2e-test AVALANCHEGO_BUILD_PATH=/tmp/e2e-test/avalanchego ./scripts/install_avalanchego_release.sh
- name: Build Subnet-EVM Plugin Binary
shell: bash
run: go mod download
- name: Run simulator tests
run: ./scripts/build.sh /tmp/e2e-test/avalanchego/plugins/srEXiWaHuhNyGwPUi444Tu47ZEDwxTWrbQiuD7FmgSAQ6X7Dy
- name: Run E2E Tests
shell: bash
# skip shutdown so external simulator binary can run against the existing cluster
run: SKIP_NETWORK_RUNNER_SHUTDOWN=true RUN_SIMULATOR=true scripts/run.sh
run: AVALANCHEGO_BUILD_PATH=/tmp/e2e-test/avalanchego DATA_DIR=/tmp/e2e-test/data ./scripts/run_ginkgo.sh

release:
# needs: [lint_test, unit_test, e2e_test, simulator_test]
Expand Down
Loading