Get signature endpoint #475
Conversation
Co-authored-by: aaronbuchwald <aaron.buchwald56@gmail.com>
Co-authored-by: aaronbuchwald <aaron.buchwald56@gmail.com>
|
We should test that this endpoint correctly returns an error both via a CURL request and through the implemented Looking at the implementation, I don't think it will right now because it uses |
plugin/evm/warp_client.go
Outdated
| // NewClient returns a Client for interacting with EVM [chain] | ||
| func NewWarpClient(uri, chain string) WarpClient { | ||
| return &warpClient{ | ||
| requester: rpc.NewEndpointRequester(fmt.Sprintf("%s/ext/bc/%s/warp", uri, chain)), |
There was a problem hiding this comment.
nit: where is this endpoint from? Do we need the same chainID twice in the endpoint or does one work as well?
There was a problem hiding this comment.
The implementation has been updated since you left this comment, but the endpoint is the same as the eth rpc API, i.e. /rpc. Methods are denoted by warp_methodName in the method field.
|
I tested this endpoint both with CURL and the warp client struct. I modeled the API after
|
Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Co-authored-by: aaronbuchwald <aaron.buchwald56@gmail.com> Co-authored-by: Ceyhun Onur <ceyhun.onur@avalabs.org> Co-authored-by: cam-schultz <78878559+cam-schultz@users.noreply.github.com>
…vm into get-signature-endpoint
…vm into get-signature-endpoint
|
Closing in favor of #507 |
Why this should be merged
Adds an endpoint
warp_getSignaturethat returns the signature for a given message ID from the warp backend. This will likely be used primarily for testing purposes, but could act as an alternative to VM AppRequests.Fixes #446
How this works
Adds a new
WarpAPIand methodGetSignature, and a corresponding clientWarpClientand method.How this was tested
CI tests. Manual testing via CURL and a standalone app that uses
WarpClient