Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release locks on return #470

Merged
merged 1 commit into from
Jan 30, 2023
Merged

release locks on return #470

merged 1 commit into from
Jan 30, 2023

Conversation

darioush
Copy link
Collaborator

Should release locks we take on returning from functions.

@darioush darioush marked this pull request as ready for review January 30, 2023 21:24
aaronbuchwald
aaronbuchwald approved these changes Jan 30, 2023
View reviewed changes
Copy link
Collaborator

@aaronbuchwald aaronbuchwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaronbuchwald aaronbuchwald merged commit 76e3fe2 into master Jan 30, 2023
@aaronbuchwald aaronbuchwald deleted the lock-fixes branch January 30, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronbuchwald aaronbuchwald aaronbuchwald approved these changes

@anusha-ctrl anusha-ctrl anusha-ctrl approved these changes

@ceyonur ceyonur Awaiting requested review from ceyonur ceyonur is a code owner

@patrick-ogrady patrick-ogrady Awaiting requested review from patrick-ogrady

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@darioush @aaronbuchwald @anusha-ctrl