nil timestamp in genesis should be upgradeable #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darioush
requested review from
ceyonur,
patrick-ogrady and
aaronbuchwald
as code owners
holisticode
approved these changes
Jan 26, 2023
aaronbuchwald
approved these changes
Jan 26, 2023
ceyonur
reviewed
Jan 27, 2023
…bs/subnet-evm into fix-genesis-disabled-upgradebytes
ceyonur
approved these changes
Jan 27, 2023
aaronbuchwald
approved these changes
Jan 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
niltimestamp does not enable the precompile at genesis, so it should be upgradeable.How this works
Checks for
niltimestamp explicitlyHow this was tested
UT