-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge coreth 0.8.6 #43
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
if metrics.EnabledExpensive { | ||
defer func(start time.Time) { s.AccountReads += time.Since(start) }(time.Now()) | ||
s.AccountReads += time.Since(start) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so much cleaner haha
@@ -67,6 +70,10 @@ func (hc *httpConn) writeJSONSkipDeadline(context.Context, interface{}, bool) er | |||
panic("writeJSON called on httpConn") | |||
} | |||
|
|||
func (hc *httpConn) peerInfo() PeerInfo { | |||
panic("peerInfo called on httpConn") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jeeez, aggressive
096e4a4
to
439f72f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merges coreth 0.8.6 tag