Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaned up ANR install process #155

Merged
merged 8 commits into from
Jul 21, 2022
Merged

Cleaned up ANR install process #155

merged 8 commits into from
Jul 21, 2022

Conversation

dasconnor
Copy link
Contributor

Use go install instead of unpacking a binary.

Closes #152

@dasconnor dasconnor changed the title Cleaned up install process Cleaned up ANR install process Jul 19, 2022
@dasconnor
Copy link
Contributor Author

This is blocked on the latest ANR release.

@ceyonur
Copy link
Collaborator

ceyonur commented Jul 20, 2022

Does this also close #99 ?

@dasconnor
Copy link
Contributor Author

I don't think this will close #99 because this only addresses the network runner, not avalanchego. One question for you @ceyonur, do you have any idea why the pipeline is failing? Looks like the fee config test. Not sure how/why that could be affected.

@dasconnor
Copy link
Contributor Author

ok, finally passed

aaronbuchwald
aaronbuchwald approved these changes Jul 21, 2022
View reviewed changes
Copy link
Collaborator

@aaronbuchwald aaronbuchwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaronbuchwald aaronbuchwald merged commit 63a4260 into master Jul 21, 2022
@ceyonur ceyonur mentioned this pull request Jul 25, 2022
Merged
@ceyonur ceyonur deleted the changeAnrInstall branch February 22, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darioush darioush darioush approved these changes

@aaronbuchwald aaronbuchwald aaronbuchwald approved these changes

@ceyonur ceyonur Awaiting requested review from ceyonur ceyonur is a code owner

@patrick-ogrady patrick-ogrady Awaiting requested review from patrick-ogrady

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
subnet-evm@v0.2.6
Development

Successfully merging this pull request may close these issues.

Convert subnet-evm E2E tests to use go install
5 participants
@dasconnor @ceyonur @darioush @aaronbuchwald @yulin-dong