Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: add tag for commit hash #1222

Merged
merged 1 commit into from
Jun 26, 2024
Merged

docker: add tag for commit hash #1222

merged 1 commit into from
Jun 26, 2024

Conversation

darioush
Copy link
Collaborator

@darioush darioush commented Jun 24, 2024

Having the commit hash allows to refer to a different commits on a branch (since the image may be cached locally by tag)
This is useful in testing

@darioush darioush marked this pull request as ready for review June 24, 2024 17:28
@darioush darioush requested a review from ceyonur as a code owner June 24, 2024 17:28
Copy link
Contributor

@ARR4N ARR4N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darioush darioush merged commit 88a4326 into master Jun 26, 2024
12 checks passed
@darioush darioush deleted the docker-tag-commit branch June 26, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants