Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coreth sync v0.13.1 rc.5 #1111

Merged
merged 7 commits into from
Mar 1, 2024
Merged

Coreth sync v0.13.1 rc.5 #1111

merged 7 commits into from
Mar 1, 2024

Conversation

ceyonur
Copy link
Collaborator

@ceyonur ceyonur commented Mar 1, 2024

Syncs coreth up to v0.13.1-rc.5

@ceyonur ceyonur requested a review from darioush as a code owner March 1, 2024 13:11
@ceyonur ceyonur marked this pull request as draft March 1, 2024 13:15
@ceyonur ceyonur marked this pull request as ready for review March 1, 2024 14:42
darioush
darioush previously approved these changes Mar 1, 2024
@@ -264,11 +263,12 @@ func (c *Config) SetDefaults() {
c.CommitInterval = defaultCommitInterval
c.SnapshotWait = defaultSnapshotWait
c.RegossipFrequency.Duration = defaultRegossipFrequency
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May want to move this below the changes to keep ordering from config

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

patrick-ogrady
patrick-ogrady previously approved these changes Mar 1, 2024
@ceyonur ceyonur dismissed stale reviews from patrick-ogrady and darioush via dd05791 March 1, 2024 15:41
@ceyonur ceyonur merged commit b4b595e into master Mar 1, 2024
10 checks passed
@ceyonur ceyonur deleted the coreth-sync-v0.13.1-rc.5 branch March 1, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants