Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AV-1596] Add priority regossip addresses to locals #104

Merged
merged 1 commit into from
May 13, 2022
Merged

[AV-1596] Add priority regossip addresses to locals #104

merged 1 commit into from
May 13, 2022

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented May 13, 2022 •
edited
Loading

Closes: #102

@patrick-ogrady patrick-ogrady changed the title Add priority regossip addresses to locals [AV-1596] Add priority regossip addresses to locals May 13, 2022
patrick-ogrady
patrick-ogrady commented May 13, 2022
View reviewed changes
plugin/evm/vm.go
@@ -273,6 +273,7 @@ func (vm *VM) Initialize(
ethConfig.RPCEVMTimeout = vm.config.APIMaxDuration.Duration
ethConfig.RPCTxFeeCap = vm.config.RPCTxFeeCap
ethConfig.TxPool.NoLocals = !vm.config.LocalTxsEnabled
ethConfig.TxPool.Locals = vm.config.PriorityRegossipAddresses
Copy link
Contributor Author

@patrick-ogrady patrick-ogrady May 13, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More locals will be added during txpool exec if NoLocals=false

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just for init: https://github.com/ava-labs/coreth/blob/f59716999fd10446a91a9aa2e019203f555dbac0/core/tx_pool.go#L331-L334

ceyonur
ceyonur approved these changes May 13, 2022
View reviewed changes
Copy link
Collaborator

@ceyonur ceyonur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a cost-effective PR! LGTM

@patrick-ogrady patrick-ogrady merged commit 23c3964 into master May 13, 2022
@patrick-ogrady patrick-ogrady deleted the add-priority-regossip-to-locals branch May 13, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darioush darioush darioush approved these changes

@ceyonur ceyonur ceyonur approved these changes

@dboehm-avalabs dboehm-avalabs Awaiting requested review from dboehm-avalabs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Priority Regossip Addresses Eviction Exempt
3 participants
@patrick-ogrady @darioush @ceyonur