Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update run script to work with a branch/commit/tag of AvalancheGo #392

Closed
aaronbuchwald opened this issue Dec 5, 2022 · 1 comment
Closed

Update run script to work with a branch/commit/tag of AvalancheGo #392

aaronbuchwald opened this issue Dec 5, 2022 · 1 comment
Labels
ci cleanup good first issue Good for newcomers
Milestone
subnet-evm@Future...

Comments

@aaronbuchwald
Copy link
Collaborator

Currently the run script requires a release of AvalancheGo since it pulls in a binary release of AvalancheGo to run alongside subnet-evm. This should not be a requirement, so we should modify it to optionally checkout a branch of AvalancheGo and build the AvalancheGo binary locally instead of making a release of AvalancheGo a hard requirement to use the run script.

Ex. this PR was broken by the requirement of using an AvalancheGo release instead of a tag: #391
@aaronbuchwald
Copy link
Collaborator Author

Addressed by #425

darioush pushed a commit that referenced this issue Jan 23, 2024
@aaronbuchwald @darioush
Update acceptor tip before sending chain events to subscribers (#392)
7d360b2
ceyonur pushed a commit that referenced this issue Jan 23, 2024
@darioush @aaronbuchwald
Update acceptor tip before sending chain events to subscribers (#392) (…
b14bbb2 
…#1060)

Co-authored-by: aaronbuchwald <aaron.buchwald56@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci cleanup good first issue Good for newcomers
Projects
None yet
Milestone
subnet-evm@Future Release
Development

No branches or pull requests
1 participant
@aaronbuchwald