Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use p2p.Network #384

Merged
merged 8 commits into from
Nov 30, 2023
Merged

Use p2p.Network #384

merged 8 commits into from
Nov 30, 2023

Conversation

joshua-kim
Copy link
Contributor

@joshua-kim joshua-kim commented Nov 8, 2023

Why this should be merged

Uses the new p2p.Network component

How this works

Uses the new p2p.Network component which provides default values for the client. p2p.Network manages an internal peer set which is used as a default if no sampling strategy is provided.

How this was tested

CI

peer/network.go Outdated Show resolved Hide resolved
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
@joshua-kim joshua-kim self-assigned this Nov 29, 2023
@joshua-kim joshua-kim marked this pull request as ready for review November 29, 2023 21:34
@joshua-kim joshua-kim changed the title Update to Refactored SDK Use p2p.Network Nov 29, 2023
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
This reverts commit e9b59ee.
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
@darioush darioush merged commit 8e388ba into master Nov 30, 2023
8 checks passed
@darioush darioush deleted the network branch November 30, 2023 01:45
darioush added a commit that referenced this pull request Dec 1, 2023
This reverts commit 8e388ba.
darioush added a commit that referenced this pull request Dec 1, 2023
joshua-kim added a commit that referenced this pull request Dec 6, 2023
commit abde8d6
Author: Stephen Buttolph <stephen@avalabs.org>
Date:   Wed Dec 6 13:39:32 2023 -0500

    Update avalanchego dependency to v1.10.18-rc.0 (#415)

commit bed4cf7
Author: Stephen Buttolph <stephen@avalabs.org>
Date:   Fri Dec 1 16:48:28 2023 -0500

    Clarify bonus block inclusion in atomic trie (#412)

commit 631a5bd
Author: Darioush Jalali <darioush.jalali@avalabs.org>
Date:   Fri Dec 1 13:33:07 2023 -0800

    Fix trie reuse after Commit in atomic sync (#411)

    Co-authored-by: aaronbuchwald <aaron.buchwald56@gmail.com>
    Co-authored-by: Stephen Buttolph <stephen@avalabs.org>

commit 6d7e6b8
Author: Darioush Jalali <darioush.jalali@avalabs.org>
Date:   Fri Dec 1 12:39:07 2023 -0800

    Fix overwriting of atomic trie roots (#407)

commit 0a6a7a3
Author: Darioush Jalali <darioush.jalali@avalabs.org>
Date:   Fri Dec 1 12:09:32 2023 -0800

    Skip bonus blocks applying atomic ops from trie to shared memory (#409)

commit 0eef20a
Author: Stephen Buttolph <stephen@avalabs.org>
Date:   Fri Dec 1 13:21:45 2023 -0500

    Improve logging of unexpected state sync errors (#410)

commit f6899f9
Author: Stephen Buttolph <stephen@avalabs.org>
Date:   Fri Dec 1 13:10:26 2023 -0500

    Simplify atomic root acceptance (#406)

    Co-authored-by: aaronbuchwald <aaron.buchwald56@gmail.com>

commit 8e388ba
Author: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
Date:   Wed Nov 29 20:45:05 2023 -0500

    Use `p2p.Network` (#384)

Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
darioush pushed a commit that referenced this pull request Apr 25, 2024
darioush pushed a commit that referenced this pull request Apr 25, 2024
* bump versions

* change p2p network code

* Revert "change p2p network code"

This reverts commit 02add5300a6da68b1590598ad7a65af1c99a0156.

* Use `p2p.Network` (#384)

---------

Co-authored-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Status: Backlog 🗄
Development

Successfully merging this pull request may close these issues.

3 participants