Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: Add avalanchego e2e job #305

Merged
merged 3 commits into from
Aug 29, 2023
Merged

e2e: Add avalanchego e2e job #305

merged 3 commits into from
Aug 29, 2023

Conversation

marun
Copy link
Contributor

@marun marun commented Aug 21, 2023 •
edited
Loading

Why this should be merged

Adds a CI job to run the pinned version of the avalanchego e2e tests against the latest version of coreth. Once the PRs for #1547 are merged to avalanchego to ensure equivalent coverage to the current kurtosis e2e, the current coreth kurtosis e2e job can be disabled.

How this works

A new script in the coreth repo - ./scripts/tests.e2e.sh:

  • checks out the target version of AvalancheGo
  • configures it to use the local working directory as its coreth dependency
  • builds avalanchego binary
  • runs the AvalancheGo e2e test script

How this was tested

Checked that the new AvalancheGo E2E Tests job exists and is passing.

@marun marun mentioned this pull request Aug 20, 2023
Closed
16 tasks
@marun marun force-pushed the e2e-add-avalanchego-job branch 4 times, most recently from 7c97047 to cf13fc0 Compare August 21, 2023 17:02
aaronbuchwald
aaronbuchwald reviewed Aug 23, 2023
View reviewed changes
scripts/tests.e2e.sh Outdated Show resolved Hide resolved
aaronbuchwald
aaronbuchwald requested changes Aug 23, 2023
View reviewed changes
Copy link
Collaborator

@aaronbuchwald aaronbuchwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment to re-use similar functionality from an existing script.

@marun marun self-assigned this Aug 23, 2023
@aaronbuchwald
Copy link
Collaborator

As discussed offline, it would be great to add an AVALANCHEGO_CLONE_PATH variable that we can override if desired. After that, this LGTM

@marun
Copy link
Contributor Author

marun commented Aug 23, 2023 •
edited
Loading

Avalanchego clone path is now configurable. Also fixed bug in existing clone maintenance (fetch instead of pull).

@aaronbuchwald aaronbuchwald merged commit 3f5dc8a into master Aug 29, 2023
8 of 9 checks passed
@aaronbuchwald aaronbuchwald deleted the e2e-add-avalanchego-job branch August 29, 2023 17:17
joshua-kim added a commit to joshua-kim/coreth that referenced this pull request Aug 30, 2023
@joshua-kim
Squashed commit of the following:
d8aab62 
commit 3f5dc8a
Author: marun <maru.newby@avalabs.org>
Date:   Tue Aug 29 10:17:05 2023 -0700

    e2e: Add avalanchego e2e job (ava-labs#305)

    * e2e: Add avalanchego e2e job

    * fixup: Use currently supported golang version

    * fixup: Enable configurable avalanchego clone path

commit 4ef26a0
Author: Darioush Jalali <darioush.jalali@avalabs.org>
Date:   Mon Aug 28 06:38:44 2023 -0700

    bump go version in dockerfile (ava-labs#311)

commit 505a6ab
Author: aaronbuchwald <aaron.buchwald56@gmail.com>
Date:   Fri Aug 25 15:43:09 2023 -0400

    core/state/snapshot: increase batch size during diffToDisk (ava-labs#309)

commit cca3e00
Author: marun <maru.newby@avalabs.org>
Date:   Fri Aug 25 09:44:42 2023 -0700

    Bump golang version to 1.19.12 for CI (ava-labs#306)

    * Bump golang version to 1.19.12 for CI

    Also bump targeted version of avalanchego to the v1.10.8 (which also
    uses golang 1.19.12).

    * fixup: Update go-version specification for consistency with other repos

commit 42ba830
Author: Darioush Jalali <darioush.jalali@avalabs.org>
Date:   Fri Aug 25 09:44:12 2023 -0700

    add upstream test: TestClientBatchRequest_len (ava-labs#307)

commit 08e2b6e
Author: Stephen Buttolph <stephen@avalabs.org>
Date:   Wed Aug 23 18:09:51 2023 -0400

    Update avalanchego dependency to v1.10.9-rc.4 (ava-labs#308)

commit 5cd24c3
Author: Darioush Jalali <darioush.jalali@avalabs.org>
Date:   Wed Aug 23 08:48:01 2023 -0700

    node/config.go: remove unused options (ava-labs#304)

    * node/config.go: remove unused graphql options

    * remove more unused config

commit 8ea8b18
Author: aaronbuchwald <aaron.buchwald56@gmail.com>
Date:   Tue Aug 15 11:18:29 2023 -0400

    Add security file based on AvalancheGo (ava-labs#303)

commit 00214b1
Author: Stephen Buttolph <stephen@avalabs.org>
Date:   Mon Aug 14 14:58:07 2023 -0400

    Update AVAX client implementation and interface to align types (ava-labs#301)

commit 5666553
Author: Ceyhun Onur <ceyhun.onur@avalabs.org>
Date:   Mon Aug 14 21:38:04 2023 +0300

    renamed flags (ava-labs#298)

    * renamed flags

    * rename admin api flags

    * add deprecation

commit e7645fa
Author: Ikko Eltociear Ashimine <eltociear@gmail.com>
Date:   Thu Aug 10 01:21:44 2023 +0900

    Fix typo in sync/README.md (ava-labs#296)
darioush pushed a commit that referenced this pull request Apr 25, 2024
@magnusironroot @Dkerby
modify dfk chain testnet upgrade bytes to disable contract deployer a…
91778ae 
…llowlist (#305)

Co-authored-by: Drew Kerby <dkerby@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darioush darioush darioush approved these changes

@aaronbuchwald aaronbuchwald aaronbuchwald approved these changes

@ceyonur ceyonur Awaiting requested review from ceyonur ceyonur is a code owner

Assignees

@marun marun

Labels
None yet
Projects
No open projects
EVM
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marun @aaronbuchwald @darioush