database: add applicable dbtests for linkeddb #3486
+63
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darioush
commented
Oct 21, 2024
Signed-off-by: Darioush Jalali <darioush.jalali@avalabs.org>
database/linkeddb/linkeddb.go
Outdated
| @@ -281,7 +281,7 @@ func (ldb *linkedDB) getHeadKey() ([]byte, error) { | |||
| func (ldb *linkedDB) putHeadKey(key []byte) error { | |||
| ldb.headKeyIsUpdated = true | |||
| ldb.updatedHeadKeyExists = true | |||
| ldb.updatedHeadKey = key | |||
| ldb.updatedHeadKey = slices.Clone(key) | |||
There was a problem hiding this comment.
On mobile right now - but I think there are other instances in the linkeddb that we need to perform a copy
There was a problem hiding this comment.
In Put we hold a direct reference to key which can be problematic:
oldHead.Previous = keyThere was a problem hiding this comment.
I think putting the copy in putHeadKey results in an unnecessary copy during Delete as well. Maybe we could copy the key in Put once we know we are going to hold a reference to it (aka after we check that we aren't overwriting an existing node)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Improves test coverage and fixes an edge case in linkeddb.
How this works
Splits the database tests into TestsBasic and Tests, where TestsBasic can run only with a KeyValueReaderWriterDeleter.
Note linkeddb doesn't really implement the interface for Iteratee, as the iteration is not guaranteed to be ordered.
Adds a key modification step to TestMemorySafetyDatabase which would have identified this edge case as the fuzzer does not seem to find it.
How this was tested
CI