Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change misleading protobuf comments #3435

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Change misleading protobuf comments #3435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f7824b
Change misleading protobuf comment
yacovm Oct 1, 2024
35a91c7
Merge branch 'master' into changemisleadingproto
StephenButtolph Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions proto/p2p/p2p.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,13 +363,13 @@ message PullQuery {
message Chits {
// Chain being responded from
bytes chain_id = 1;
// Request id of the original PushQuery/PullQuery request
// Request ID of the original PushQuery/PullQuery request
uint32 request_id = 2;
// Currently preferred block
// ID of the currently preferred block
bytes preferred_id = 3;
// Last accepted block
// ID of the last accepted block
bytes accepted_id = 4;
// Currently preferred block at the requested height
// ID of the currently preferred block at the requested height
bytes preferred_id_at_height = 5;
}

Expand Down
8 changes: 4 additions & 4 deletions proto/pb/p2p/p2p.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.