Set local C-Chain genesis timestamp to InitiallyActiveTime #3413
Conversation
| @@ -91,6 +91,6 @@ | |||
| } | |||
| } | |||
| ], | |||
| "cChainGenesis": "{\"config\":{\"chainId\":43112,\"homesteadBlock\":0,\"daoForkBlock\":0,\"daoForkSupport\":true,\"eip150Block\":0,\"eip150Hash\":\"0x2086799aeebeae135c246c65021c82b4e15a2c451340993aacfd2751886514f0\",\"eip155Block\":0,\"eip158Block\":0,\"byzantiumBlock\":0,\"constantinopleBlock\":0,\"petersburgBlock\":0,\"istanbulBlock\":0,\"muirGlacierBlock\":0,\"apricotPhase1BlockTimestamp\":0,\"apricotPhase2BlockTimestamp\":0},\"nonce\":\"0x0\",\"timestamp\":\"0x0\",\"extraData\":\"0x00\",\"gasLimit\":\"0x5f5e100\",\"difficulty\":\"0x0\",\"mixHash\":\"0x0000000000000000000000000000000000000000000000000000000000000000\",\"coinbase\":\"0x0000000000000000000000000000000000000000\",\"alloc\":{\"8db97C7cEcE249c2b98bDC0226Cc4C2A57BF52FC\":{\"balance\":\"0x295BE96E64066972000000\"}},\"number\":\"0x0\",\"gasUsed\":\"0x0\",\"parentHash\":\"0x0000000000000000000000000000000000000000000000000000000000000000\"}", | |||
| "cChainGenesis": "{\"config\":{\"chainId\":43112,\"homesteadBlock\":0,\"daoForkBlock\":0,\"daoForkSupport\":true,\"eip150Block\":0,\"eip150Hash\":\"0x2086799aeebeae135c246c65021c82b4e15a2c451340993aacfd2751886514f0\",\"eip155Block\":0,\"eip158Block\":0,\"byzantiumBlock\":0,\"constantinopleBlock\":0,\"petersburgBlock\":0,\"istanbulBlock\":0,\"muirGlacierBlock\":0,\"apricotPhase1BlockTimestamp\":0,\"apricotPhase2BlockTimestamp\":0},\"nonce\":\"0x0\",\"timestamp\":\"0x5FCB13D0\",\"extraData\":\"0x00\",\"gasLimit\":\"0x5f5e100\",\"difficulty\":\"0x0\",\"mixHash\":\"0x0000000000000000000000000000000000000000000000000000000000000000\",\"coinbase\":\"0x0000000000000000000000000000000000000000\",\"alloc\":{\"8db97C7cEcE249c2b98bDC0226Cc4C2A57BF52FC\":{\"balance\":\"0x295BE96E64066972000000\"}},\"number\":\"0x0\",\"gasUsed\":\"0x0\",\"parentHash\":\"0x0000000000000000000000000000000000000000000000000000000000000000\"}", | |||
There was a problem hiding this comment.
do you mind explaining how 0x5FCB13D0 is calculated?
There was a problem hiding this comment.
Sorry I should have made that more clear from the start.
It is InitiallyActiveTime.Unix() represented in hexadecimal to be put in the genesis
There was a problem hiding this comment.
Any ideas for how I could better document that or make it less error prone? The embedded JSON makes it a bit harder to do.
There was a problem hiding this comment.
In retrospect, instead of using:
//go:embed genesis_local.json
localGenesisConfigJSON []byte
We can have just put a Golang object and add an init() function which marshals it into the bytes of localGenesisConfigJSON
There was a problem hiding this comment.
It is InitiallyActiveTime.Unix() represented in hexadecimal to be put in the genesis
It's possible to add a unit test that asserts it is the case.
There was a problem hiding this comment.
Decided to leave it with the //go:embed approach for now to limit the changes for fixing this issue, but added a unit test that will break if the InitiallyActiveTime is ever changes.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Why this should be merged
v1.11.11coreth#660How this works
Sets the local genesis C-Chain timestamp to the InitiallyActiveTime
How this was tested
Running node with:
./build/avalanchego --sybil-protection-enabled=false --network-id=localAnd checking that there is a base fee returned for the genesis block (would previously return a null result):