Bound GetNextStakerChangeTime for ACP-77 #3411
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
For ACP-77, when checking for the maximum allowed block time, we need to search for the first time that a SoV will need to be deactivated. To perform this search efficiently, we should bound that search as much as possible. This PR introduces a maximum time to
GetNextStakerChangeTime
which will be used to implement this efficient search.How this works
GetNextStakerChangeTime
verification last in the timestamp checks.Banff
block timestamp verification and theAdvanceTimeTx
verificationAdvanceTimeTx
. However, it makes it less strict, and this transaction is no longer allowed to be issued. So this is a backwards compatible change.How this was tested
GetNextStakerChangeTime
andNextBlockTime