Fix TestSubnetValidatorBLSKeyDiffAfterExpiry
#3409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
added
testing
StephenButtolph
commented
Sep 22, 2024
| vm.State, | ||
| nodeID, | ||
| subnetID, | ||
| primaryEndHeight, |
There was a problem hiding this comment.
This should have been height.
StephenButtolph
commented
Sep 22, 2024
| vm.State, | ||
| nodeID, | ||
| constants.PrimaryNetworkID, | ||
| primaryEndHeight, |
There was a problem hiding this comment.
This should have been height.
tsachiherman
approved these changes
Sep 22, 2024
darioush
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
The loop was intended to verify that the BLS keys were properly set for every height in the expected ranges. However, the test currently just checks the same heights over-and-over again.
How this works
Replaces the repeated loop invocations with multiple test runs for each height.
How this was tested