Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid including 'failed' in debug log messages #3361

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Avoid including 'failed' in debug log messages #3361

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b9cc68
Avoid including 'failed' in debug log messages
marun Sep 4, 2024
b1c6ff6
fixup: Respond to review feedback
marun Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions snow/engine/snowman/engine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,7 +587,7 @@ func (e *Engine) sendChits(ctx context.Context, nodeID ids.NodeID, requestID uin
// Because we only return accepted state here, it's fairly likely
// that the requested height is higher than the last accepted block.
// That means that this code path is actually quite common.
e.Ctx.Log.Debug("failed fetching accepted block",
e.Ctx.Log.Debug("unable to retrieve accepted block",
zap.Stringer("nodeID", nodeID),
zap.Uint64("requestedHeight", requestedHeight),
zap.Uint64("lastAcceptedHeight", lastAcceptedHeight),
Expand Down Expand Up @@ -615,7 +615,7 @@ func (e *Engine) sendChits(ctx context.Context, nodeID ids.NodeID, requestID uin
// Because it is possible for a byzantine node to spam requests at
// old heights on a pruning network, we log this as debug. However,
// this case is unexpected to be hit by correct peers.
e.Ctx.Log.Debug("failed fetching accepted block",
e.Ctx.Log.Debug("unable to retrieve accepted block",
zap.Stringer("nodeID", nodeID),
zap.Uint64("requestedHeight", requestedHeight),
zap.Uint64("lastAcceptedHeight", lastAcceptedHeight),
Expand All @@ -630,7 +630,7 @@ func (e *Engine) sendChits(ctx context.Context, nodeID ids.NodeID, requestID uin
var ok bool
preferenceAtHeight, ok = e.Consensus.PreferenceAtHeight(requestedHeight)
if !ok {
e.Ctx.Log.Debug("failed fetching processing block",
e.Ctx.Log.Debug("processing block not found",
StephenButtolph marked this conversation as resolved.
Show resolved Hide resolved
zap.Stringer("nodeID", nodeID),
zap.Uint64("requestedHeight", requestedHeight),
zap.Uint64("lastAcceptedHeight", lastAcceptedHeight),
Expand Down
Loading