Allow P-chain wallet to be used by the platformvm #3314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacovm
reviewed
Aug 20, 2024
wallet/chain/p/client.go
Outdated
| } | ||
| } | ||
|
|
||
| type client struct { |
There was a problem hiding this comment.
I am wondering if it is not simpler to just export these fields? The constructor doesn't do anything special so i think it might make sense to skip it altogether and just initialize the instance with its fields (exported) directly.
There was a problem hiding this comment.
The wrapping function is nice to enforce that they are provided imo (as the struct is not useful without populating them).
If this signature looks weird I'd be down to unexport the Client type entirely to avoid invalid use.
yacovm
approved these changes
Aug 20, 2024
marun
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This allows the
p.Walletto be imported by packages that are imported by thevms/platformvmpackage. This will be used to expose the full P-chain wallet in platformvm unit tests.How this works
The only dependency the wallet has on
vms/platformvmis for the client operations. These have been factored out into an interface that can be populated with either a rpc client or any custom client (which will be defined in the unit tests)How this was tested
This is a pure refactor, existing CI covers the impacted files.