Refactor state tests to always use initialized state #3310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhrubabasu
approved these changes
Aug 19, 2024
StephenButtolph
commented
Aug 19, 2024
Comment on lines
+693
to
+696
| test.checkStakerInState(require, rebuiltState, staker) | ||
| test.checkValidatorsSet(require, rebuiltState, staker) | ||
| test.checkValidatorUptimes(require, rebuiltState, staker) | ||
| test.checkDiffs(require, rebuiltState, staker, 0 /*height*/) |
There was a problem hiding this comment.
These were checking the wrong state 😞.
| @@ -675,7 +674,8 @@ func TestPersistStakers(t *testing.T) { | |||
| t.Run(fmt.Sprintf("%s - subnetID %s", name, subnetID), func(t *testing.T) { | |||
| require := require.New(t) | |||
|
|
|||
| state, db := newUninitializedState(require) | |||
There was a problem hiding this comment.
Using an uninitialized state here was super jank imo
| }) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| func newInitializedState(require *require.Assertions) State { |
There was a problem hiding this comment.
Oddly enough, this wouldn't call load previously... so the initialization flow wasn't as expected for a normal initialization.
marun
reviewed
Aug 19, 2024
marun
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Previously some tests relied on using an uninitialized testing struct.
How this works
genesistestpackage so that constructing a simpleStateinstance is easier for external packages.How this was tested