Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add network upgrades to chain ctx #3283

Merged
merged 8 commits into from
Aug 13, 2024
Merged

Conversation

ceyonur
Copy link
Contributor

@ceyonur ceyonur commented Aug 9, 2024

Why this should be merged

Network upgrade configs are dynamic for non-production (mainnet, fuji) + non-local chains. Chains should be aware that any changed network upgrade and configure themselves accordingly.

Related Coreth PR: https://github.com/ava-labs/coreth/pull/630/files

How this works

This adds the specified (or default) network upgrade configs to chain context.

How this was tested

Locally (with coreth + subnet-evm)

@ceyonur ceyonur marked this pull request as ready for review August 9, 2024 16:00
@ceyonur ceyonur self-assigned this Aug 9, 2024
proto/vm/vm.proto Outdated Show resolved Hide resolved
proto/vm/vm.proto Outdated Show resolved Hide resolved
@meaghanfitzgerald meaghanfitzgerald added this to the v1.12.0-prerelease milestone Aug 9, 2024
@ceyonur ceyonur marked this pull request as draft August 12, 2024 12:01
@ceyonur ceyonur marked this pull request as ready for review August 12, 2024 14:23
Copy link
Contributor

@StephenButtolph StephenButtolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 nit then lgtm

vms/rpcchainvm/vm_server.go Show resolved Hide resolved
@StephenButtolph StephenButtolph added the testing This primarily focuses on testing label Aug 13, 2024
@StephenButtolph StephenButtolph added this pull request to the merge queue Aug 13, 2024
Merged via the queue into master with commit 6cbc669 Aug 13, 2024
21 checks passed
@StephenButtolph StephenButtolph deleted the network-upgrade-context branch August 13, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing This primarily focuses on testing
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants