bump coreth past upgrade schedule refactor #3278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darioush
commented
Aug 7, 2024
| @@ -149,7 +150,8 @@ func NewTestGenesis( | |||
| // Define C-Chain genesis | |||
| cChainGenesis := &core.Genesis{ | |||
| Config: params.AvalancheLocalChainConfig, | |||
| Difficulty: big.NewInt(0), // Difficulty is a mandatory field | |||
| Difficulty: big.NewInt(0), // Difficulty is a mandatory field | |||
| Timestamp: uint64(upgrade.InitiallyActiveTime.Unix()), // This time enables Avalanche upgrades by default | |||
There was a problem hiding this comment.
this is needed for backwards compatibility as params.AvalancheLocalChainConfig now uses avalanchego InitiallyActiveTime instead of genesis to activate avalanche upgrades (specifically ap3 which also impacts the outcome of genesis)
marun
reviewed
Aug 8, 2024
marun
approved these changes
Aug 8, 2024
StephenButtolph
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Fixes the upgrade test, removes deprecated constants.
How this works
go get github.com/ava-labs/coreth@v0.13.8-fix-genesis-upgrade
How this was tested
CI