Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tmpnet] Enable network restart to simplify iteration #3272

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

marun
Copy link
Contributor

@marun marun commented Aug 6, 2024

Why this should be merged

When making changes to avalanchego or VM binaries as part of e2e iteration, it may be useful to restart a running network instead of having to start a new one.

How this works

Adds --restart-network flag for e2e test suite.

How this was tested

CI against regression, manually for usage:

[SynchronizedBeforeSuite]
/home/me/src/avalanchego/master/tests/e2e/e2e_test.go:41
  Loaded a network configured at /home/me/.tmpnet/networks/20240806-105414.807586-avalanchego-e2e
   restarting network
  Started node "NodeID-5drktRkarrPqdHhKKRpcP6iM94ckg5Xhy"
   waiting for node NodeID-5drktRkarrPqdHhKKRpcP6iM94ckg5Xhy to report healthy
  Started node "NodeID-8kXEqbVv9vZMNyUtUTnVcmXJtQvuEPS9X"
   waiting for node NodeID-8kXEqbVv9vZMNyUtUTnVcmXJtQvuEPS9X to report healthy
  network URIs:  [{NodeID:NodeID-5drktRkarrPqdHhKKRpcP6iM94ckg5Xhy URI:http://127.0.0.1:44575} {NodeID:NodeID-8kXEqbVv9vZMNyUtUTnVcmXJtQvuEPS9X URI:http://127.0.0.1:42131}]
  test data server URI:  http://127.0.0.1:40503
[SynchronizedBeforeSuite] PASSED [12.919 seconds]

@marun marun added the testing This primarily focuses on testing label Aug 6, 2024
@marun marun self-assigned this Aug 6, 2024
@StephenButtolph StephenButtolph added this pull request to the merge queue Aug 7, 2024
Merged via the queue into master with commit 6626d2b Aug 7, 2024
21 checks passed
@StephenButtolph StephenButtolph deleted the tmpnet-add-restart branch August 7, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing This primarily focuses on testing
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants