Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add suggestions to update Local.StartTime #3233

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Add suggestions to update Local.StartTime #3233

merged 1 commit into from
Jul 25, 2024

Conversation

StephenButtolph
Copy link
Contributor

Why this should be merged

  • Modifies a test so that it won't fail in 9 months.
  • Uses time.Date rather than time.Unix for readability
  • Renames some vars

How this works

  • Just a refactor / suggestions

How this was tested

  • CI

@StephenButtolph StephenButtolph changed the title Add suggestions from code review Add suggestions to update Local.StartTime Jul 25, 2024
@StephenButtolph StephenButtolph merged commit 7e8bc43 into update-local-starttime Jul 25, 2024
18 checks passed
@StephenButtolph StephenButtolph deleted the update-local-starttime-suggestions branch July 25, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceyonur ceyonur ceyonur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StephenButtolph @ceyonur