-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove block.Status
#3158
Merged
Merged
Remove block.Status
#3158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alanchego into remove-block-status-for-real
StephenButtolph
commented
Jul 1, 2024
StephenButtolph
commented
Jul 5, 2024
StephenButtolph
requested review from
abi87,
danlaine and
dhrubabasu
as code owners
July 6, 2024 01:13
marun
reviewed
Jul 10, 2024
marun
approved these changes
Jul 11, 2024
dhrubabasu
reviewed
Jul 16, 2024
joshua-kim
approved these changes
Jul 16, 2024
dhrubabasu
approved these changes
Jul 16, 2024
tsachiherman
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. just one comment above.
…alanchego into remove-block-status-for-real
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This PR is the culmination of:
Decided
from theConsensus
interface #3123event.Blocker
intojob.Scheduler
#3125deliver
#3130wasIssued
withshouldIssueBlock
#3131By removing
Status
from thesnowman.Block
interface, VMs no longer need to implement this method; which has historically been the source of many VM bugs.How this works
By removing the last usage of
snowman.Block#Status
in the bootstrapping engine, the function can be removed from the interface and all VM implementations.How this was tested
1,403,721
to1,268,418
)