P-chain - Priority fees #2867
Open
P-chain - Priority fees #2867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abi87
commented
Mar 25, 2024
vms/components/fees/tip.go
Outdated
Comment on lines
32
to
33
| if t > maxTipPercentage { | ||
| return fmt.Errorf("%w, tip percentage %d", errTipPercentageTooLarge, t) |
There was a problem hiding this comment.
q: could tip be larger than the base fee?
Signed-off-by: Alberto Benegiamo <alberto.benegiamo@gmail.com>
abi87
requested review from
danlaine,
dhrubabasu and
StephenButtolph
as code owners
abi87
force-pushed
the
p-chain_priority_fees
branch
from
b50be4b
to
25344bf
Compare
abi87
force-pushed
the
p-chain_units-fees-update
branch
from
56f9f80
to
38d0ac0
Compare
…rity_fees-fee_config
abi87
force-pushed
the
p-chain_units-fees-update
branch
from
6750a6a
to
9a4822d
Compare
|
This PR has become stale because it has been open for 30 days with no activity. Adding the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
How this works
How this was tested