Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmpnet: Ensure restart after chain creation #2675

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

marun
Copy link
Contributor

@marun marun commented Jan 29, 2024

A previous iteration of tmpnet created subnets and chains, restarted nodes, and then added validators. This was changed to create subnets, restart nodes, add validators, and create chains. This prevented the correct configuration of any chain that had explicit configuration since the configuration would only be written after the chain was created and nodes need to be restarted to see the new configuration.

So, nodes are now restarted if any chains have explicit configuration.

Restart will be tested in ava-labs/subnet-evm#1027

@marun marun added the testing This primarily focuses on testing label Jan 29, 2024
@marun marun self-assigned this Jan 29, 2024
@marun marun marked this pull request as ready for review January 29, 2024 17:44
@StephenButtolph StephenButtolph added this to the v1.10.20 milestone Jan 30, 2024
@StephenButtolph StephenButtolph added this pull request to the merge queue Jan 30, 2024
Merged via the queue into master with commit cf6935a Jan 30, 2024
17 checks passed
@StephenButtolph StephenButtolph deleted the tmpnet-chain-restart branch January 30, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing This primarily focuses on testing
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants