Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename testnet fixture to tmpnet #2307

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Rename testnet fixture to tmpnet #2307

merged 2 commits into from
Nov 30, 2023

Conversation

marun
Copy link
Contributor

@marun marun commented Nov 14, 2023 •
edited
Loading

As per the README update, changing the name of the fixture from testnet to tmpnet (short for 'temporary network') is intended to ensure a less unambiguous name. The original name of testnet was chosen in ignorance of the common use of the term to refer to a persistent blockchain network used for testing.

Also changed:

  • 'existing' is used instead of 'persistent' in reference to temporary networks that are started and stopped with the tmpnetctl tool. Referring to a temporary network as 'persistent' seemed confusing.

  • TESTNETCTL_*-prefixed env vars are now prefixed with TMPNET_ (minus the CTL) since they are used by both the tmpnetctl cli and the ginkgo test suite.

  • The root directory for storing local networks becomes .tmpnet instead of .testnetctl, also due to the path being shared between the tmpnetctl cli and the ginkgo test suite.

TODO

  • Require tests_e2e_existing job after this PR merges

@marun marun marked this pull request as ready for review November 14, 2023 17:18
@marun marun changed the title Rename testnet fixture to ephnet Rename testnet fixture to tmpnet Nov 27, 2023
@marun marun force-pushed the ephnet-name-change branch 3 times, most recently from fb2c9fd to 082a0b6 Compare November 28, 2023 09:43
@marun marun force-pushed the ephnet-name-change branch 2 times, most recently from e1615ab to 64e6996 Compare November 29, 2023 14:25
@marun marun mentioned this pull request Nov 29, 2023
Merged
3 tasks
@marun
Rename testnet fixture to ephnet
0a28ac2 
As per the README update, changing the name of the fixture to `ephnet`
(short for 'ephemeral network') is intended to ensure a less
unambiguous name. The original name of `testnet` was chosen in
ignorance of the common use of the term to refer to a persistent
blockchain network used for testing.

Also changed:

 - 'existing' is used instead of 'persistent' in reference to
 ephemeral networks that are started and stopped with the `ephnetctl`
 tool. Referring to an ephemeral network as 'persistent' seemed
 confusing.

 - `TESTNETCTL_*`-prefixed env vars are now prefixed with
 `EPHNET_` (minus the `CTL`) since they are used by both the ephnetctl
 cli and the ginkgo test suite.

 - The root directory for storing local networks becomes `.ephnet`
 instead of `.testnetctl`, also due to the path being shared between
 the ephnetctl cli and the ginkgo test suite.
@marun
fixup: rename to tmpnet
0529a02
@StephenButtolph StephenButtolph added this to the v1.10.17 milestone Nov 30, 2023
@StephenButtolph StephenButtolph added the testing This primarily focuses on testing label Nov 30, 2023
@StephenButtolph StephenButtolph added this pull request to the merge queue Nov 30, 2023
Merged via the queue into dev with commit 0ab2046 Nov 30, 2023
16 checks passed
@StephenButtolph StephenButtolph deleted the ephnet-name-change branch November 30, 2023 17:41
joshua-kim added a commit that referenced this pull request Dec 6, 2023
@joshua-kim
Squashed commit of the following:
8866972 
commit b36416d
Author: Alberto Benegiamo <alberto.benegiamo@gmail.com>
Date:   Wed Dec 6 12:12:11 2023 -0700

    Drop Pending Stakers 1 - introduced ScheduledStaker txs (#2323)

    Co-authored-by: Stephen Buttolph <stephen@avalabs.org>

commit 7df1f3a
Author: Stephen Buttolph <stephen@avalabs.org>
Date:   Wed Dec 6 13:46:56 2023 -0500

    Restrict GOPROXY (#2434)

commit 21b7ab8
Author: Stephen Buttolph <stephen@avalabs.org>
Date:   Tue Dec 5 19:43:00 2023 -0500

    Fix platformvm.SetPreference (#2429)

commit ada692a
Author: Stephen Buttolph <stephen@avalabs.org>
Date:   Tue Dec 5 17:40:03 2023 -0500

    Update minimum golang version to v1.20.12 (#2427)

commit 004a23e
Author: Dhruba Basu <7675102+dhrubabasu@users.noreply.github.com>
Date:   Tue Dec 5 12:56:25 2023 -0500

    `vms/platformvm`: Add `decisionTxs` parameter to `NewBanffProposalBlock` (#2411)

    Co-authored-by: Dan Laine <daniel.laine@avalabs.org>

commit 439dc1e
Author: Alberto Benegiamo <alberto.benegiamo@gmail.com>
Date:   Tue Dec 5 10:46:13 2023 -0700

    ProposerVM Extend windows 0 - Cleanup (#2404)

    Co-authored-by: Stephen Buttolph <stephen@avalabs.org>

commit 477157d
Author: Dhruba Basu <7675102+dhrubabasu@users.noreply.github.com>
Date:   Tue Dec 5 11:10:56 2023 -0500

    `vms/platformvm`: Cleanup some block tests (#2422)

    Co-authored-by: Dan Laine <daniel.laine@avalabs.org>

commit b6700c9
Author: Stephen Buttolph <stephen@avalabs.org>
Date:   Mon Dec 4 22:24:34 2023 -0500

    Update slices dependency to use Compare (#2424)

    Co-authored-by: James Walker <jim.walker@smartcontract.com>

commit 5d9e482
Author: Dan Laine <daniel.laine@avalabs.org>
Date:   Mon Dec 4 19:27:29 2023 -0500

    allow user of `build_fuzz.sh` to specify a directory to fuzz in (#2414)

commit 2e32281
Author: Stephen Buttolph <stephen@avalabs.org>
Date:   Mon Dec 4 18:30:41 2023 -0500

    Fix duplicated bootstrapper engine termination (#2334)

    Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
    Co-authored-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>

commit b741c19
Author: Dhruba Basu <7675102+dhrubabasu@users.noreply.github.com>
Date:   Mon Dec 4 17:49:15 2023 -0500

    `vms/platformvm`: Move `VerifyUniqueInputs` from `verifier` to `backend` (#2410)

commit 6aa20fc
Author: Dhruba Basu <7675102+dhrubabasu@users.noreply.github.com>
Date:   Mon Dec 4 17:32:07 2023 -0500

    `vms/platformvm`: Initialize txs in `Transactions` field for `BanffProposalBlock` (#2419)

commit c11accd
Author: Alberto Benegiamo <alberto.benegiamo@gmail.com>
Date:   Mon Dec 4 09:16:01 2023 -0700

    Drop Pending Stakers 0 - De-duplicate staking tx verification (#2335)

commit 05ce366
Author: marun <maru.newby@avalabs.org>
Date:   Sat Dec 2 13:33:18 2023 -0800

    testing: Update to latest version of ginkgo (#2390)

commit 04af33e
Author: Dhruba Basu <7675102+dhrubabasu@users.noreply.github.com>
Date:   Sat Dec 2 16:33:07 2023 -0500

    `vms/platformvm`: Cleanup block builder tests (#2406)

    Co-authored-by: Stephen Buttolph <stephen@avalabs.org>

commit 7623ffd
Author: Stephen Buttolph <stephen@avalabs.org>
Date:   Fri Dec 1 19:39:15 2023 -0500

    Update versions for v1.10.17 (#2394)

commit be1a2ad
Author: aaronbuchwald <aaron.buchwald56@gmail.com>
Date:   Fri Dec 1 13:31:49 2023 -0500

    Add more descriptive formatted error (#2403)

    Co-authored-by: Stephen Buttolph <stephen@avalabs.org>

commit 9b85141
Author: Dhruba Basu <7675102+dhrubabasu@users.noreply.github.com>
Date:   Thu Nov 30 12:42:36 2023 -0800

    `vms/platformvm`: Move `GetRewardUTXOs`, `GetSubnets`, and `GetChains` to `State` interface (#2402)

commit de3b16c
Author: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
Date:   Thu Nov 30 12:49:53 2023 -0500

    Add `p2p.Network` component (#2283)

    Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
    Co-authored-by: Stephen Buttolph <stephen@avalabs.org>

commit 0ab2046
Author: marun <maru.newby@avalabs.org>
Date:   Thu Nov 30 09:18:59 2023 -0800

    Rename `testnet` fixture to `tmpnet` (#2307)

commit 907b34c
Author: Stephen Buttolph <stephen@avalabs.org>
Date:   Wed Nov 29 21:32:43 2023 -0500

    Update bootstrap IPs (#2396)

commit 96d451d
Author: Stephen Buttolph <stephen@avalabs.org>
Date:   Wed Nov 29 18:15:47 2023 -0500

    Periodically PullGossip only from connected validators (#2399)

commit 0da5bcc
Author: Dan Laine <daniel.laine@avalabs.org>
Date:   Wed Nov 29 16:32:16 2023 -0500

    Remove method `CappedList` from `set.Set` (#2395)

Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceyonur ceyonur ceyonur approved these changes

@joshua-kim joshua-kim joshua-kim approved these changes

@StephenButtolph StephenButtolph StephenButtolph approved these changes

@abi87 abi87 Awaiting requested review from abi87

@gyuho gyuho Awaiting requested review from gyuho

@danlaine danlaine Awaiting requested review from danlaine

@darioush darioush Awaiting requested review from darioush

@dboehm-avalabs dboehm-avalabs Awaiting requested review from dboehm-avalabs

@hexfusion hexfusion Awaiting requested review from hexfusion

Assignees

@marun marun

Labels
testing This primarily focuses on testing
Projects
Platform Engineering Group
Archived in project
Milestone
v1.10.17
Development

Successfully merging this pull request may close these issues.
4 participants
@marun @ceyonur @joshua-kim @StephenButtolph