Added an image buffer to fix the artificial latency in sim #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DocGarbanzo
requested changes
Aug 28, 2021
DocGarbanzo
reviewed
Sep 2, 2021
donkeycar/parts/dgym.py
Outdated
|
|
||
| # go through the buffer | ||
| num_to_remove = 0 | ||
| for it in range(len(self.buffer)): |
There was a problem hiding this comment.
You can now make this more pythonic by not using the random access iterator at all but just:
for buf in in self.buffer:
if now - buf[0] >= self.delay
...
|
Great, this looks good to me, I only have one minor comment. Can you please rebase and squash all the commits into one and force-push your branch so we keep git history linear? I will merge this then. |
Maximellerbach
force-pushed
the
fix-sim-latency-delay
branch
from
82fbf5b
to
e4d2141
Compare
author Maxime Ellerbach <maxime@ellerbach.net> 1629036953 +0200 committer Maxime Ellerbach <maxime@ellerbach.net> 1630618548 +0200 added an image buffer to fix the artificial latency
Maximellerbach
force-pushed
the
fix-sim-latency-delay
branch
from
e4d2141
to
6e7d0e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously used time.sleep to simulate the latency, but this method slows down the whole loop.
I added an image/info buffer to fix this issue.
what it does:
If you have SIM_ARTIFICIAL_LATENCY=100, you should expect to have from 4 to 5 images in the buffer
tested on my machine with donkeycar in the sim