Fix passing of tub metadata #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a read tub metadata as --meta=foo:bar --meta=baz:44, but it doesn't. This change fixes it.
|
Instead of changing the complete.py template, I recommend you change Tub_v2. Look at datastore.py which has the old code. The split code is in the init procedure for Tub. If the meta conversion is handled here, the meta data could be setup in config.py or myconfig.py and passed to the tub part instead of only relying on the command line parameter. |
… between command line and config METADATA
|
@cfox570 - I have changed the code to allow what you suggested, i.e. merging |
|
Perfect. Thanks for the update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template complete.py does not support passing tub metadata
According to the docopt string, the complete template should allow to read tub metadata as
but it doesn't. This change fixes it. We also add support for the config parameter
METADATAto be merged with the command line options.