Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS Type cheking error #235

Closed
juanem1 opened this issue Mar 19, 2021 · 0 comments · Fixed by #236
Closed

TS Type cheking error #235

juanem1 opened this issue Mar 19, 2021 · 0 comments · Fixed by #236

Comments

@juanem1
Copy link

juanem1 commented Mar 19, 2021

Describe the problem

function getSigningKey() only accept string param, but null or undefined are valid for json' s with only one key.

What was the expected behavior?

TS should not show and error when calling getSigningKey() with no params or undefined param

Reproduction

async getPublicKey(kid?: string): Promise<string> {
    const client = jwksClient({
      cacheMaxAge: this.cacheMaxAge,
      jwksUri: this.url,
    });
    const key = await client.getSigningKey(kid); <- Error: string | undefined is not assignable to parameter of type 'string' 
    return key.getPublicKey();
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant