FIx: mapping of multiple action dependencies #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willvedd
reviewed
Sep 20, 2023
|
@Tenrys I'm also surprised we missed this 😬 . Thank you for pushing this. Normally I would expect unit tests but testing has been flaky in this area. I plan to create a follow-up PR that includes tests for this. |
willvedd
approved these changes
Sep 20, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Fixes an issue identical to what #844 fixed, except for dependencies this time. I'm surprised we missed this.
📚 References
It's really the same exact issue I just ran into, but for dependencies instead of secrets this time...
Sorry for not adding any tests, this is really a quick fix I needed now and figured I might as well push it here too.
🔬 Testing
Running an actions command while specifying multiple dependencies as expected works properly now.
📝 Checklist