Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename flag connection to connection name in users commands #738

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

sergiught
Copy link
Contributor

🔧 Changes

Rename flag connection to connection-name in users commands for consistency as the auth0 test commands have it named as connection-name for clarity.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught requested a review from a team as a code owner April 14, 2023 10:00
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 86.95% and no project coverage change.

Comparison is base (f764ae5) 70.83% compared to head (fe37411) 70.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #738   +/-   ##
=======================================
  Coverage   70.83%   70.83%           
=======================================
  Files          87       87           
  Lines       11211    11211           
=======================================
  Hits         7941     7941           
  Misses       2750     2750           
  Partials      520      520           
Impacted Files Coverage Δ
internal/cli/users.go 74.58% <86.95%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sergiught sergiught merged commit 94aeeee into main Apr 14, 2023
@sergiught sergiught deleted the patch/rename-users-import-conn-flag branch April 14, 2023 13:23
willvedd added a commit that referenced this pull request Apr 14, 2023
* Updating changelog and migration guide to reflect changes from last beta release

* Merging 1.0.0 changelog with previous beta releases

* Update version links

* Updating changelog and migration guide to include changes from #738

---------

Co-authored-by: Will Vedder <will.vedder@okta.com>
Co-authored-by: Sergiu Ghitea <28300158+sergiught@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants