DXCDT-409: Users commands integration tests #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g-identifiers-scripts-refactor
…409-users-integration-tests
willvedd
commented
Mar 30, 2023
Comment on lines
+463
to
+467
| if len(inputs.Email) != 0 { | ||
| user.Email = &inputs.Email | ||
| } | ||
|
|
||
| if len(inputs.Password) == 0 { | ||
| user.Password = current.Password | ||
| } else { | ||
| if len(inputs.Password) != 0 { |
There was a problem hiding this comment.
This fixes a bug where password would not be able to be update because you cannot update both email and password simultaneously.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #686 +/- ##
==========================================
+ Coverage 55.99% 56.36% +0.36%
==========================================
Files 89 89
Lines 11506 11502 -4
==========================================
+ Hits 6443 6483 +40
+ Misses 4622 4580 -42
+ Partials 441 439 -2
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ewanharris
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
A modest increase in testing coverage for the users commands. A couple new commands covered, but otherwise just some edge cases. Unfortunately, the
auth0 users importcommand is not testable, there is a bug that prevents the--no-inputflag from working as expected, requires additional input.Also included in this PR is a bug fix that previously prevented passwords from being updated.
📚 References
🔬 Testing
📝 Checklist