Fix apps shown in multi select when no app-id is passed #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiught
commented
Feb 14, 2023
| if c.GetAppType() == "" { | ||
| continue | ||
| func (c *cli) appPickerOptions(requestOpts ...management.RequestOption) pickerOptionsFunc { | ||
| requestOpts = append(requestOpts, management.Parameter("is_global", "false")) |
There was a problem hiding this comment.
After this PR we can follow up with another one where we can remove the "All Applications" hack removal from the apps display pkg to skip showing the global client.
sergiught
commented
Feb 14, 2023
| priorityOpts = append(priorityOpts, opt) | ||
| } else { | ||
| opts = append(opts, opt) | ||
| if tenant.DefaultAppID == client.GetClientID() { |
There was a problem hiding this comment.
🤔 There's very minimal usage of the default app id at the moment within the cli, could be something we might want to remove or enhance support for.
There was a problem hiding this comment.
I think it's fine to leave it as it is for now.
Widcket
approved these changes
Feb 14, 2023
willvedd
approved these changes
Feb 14, 2023
sergiught
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
This PR fixes a bug with the appPickerOptions func where it was skipping all generic app types. Furthermore we enhance the function to accept request options so we can reuse the same func within the quickstart download command and skip fetching generic app types for it.
📚 References
🔬 Testing
📝 Checklist