DXCDT-302: Fix prompts update failing for non-login prompt types #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willvedd
commented
Jan 5, 2023
| @@ -214,9 +214,12 @@ func downloadDefaultBrandingTextTranslations(prompt, language string) map[string | |||
| return nil | |||
| } | |||
|
|
|||
| selectedPrompt := allPrompts[0][prompt].(map[string]interface{}) | |||
There was a problem hiding this comment.
The issue is that the allPrompts is a set of twenty-something values, each with a single-property object pertaining to a specific prompt type.
This is why the login prompt was working, because it was the zeroth index in this set.
willvedd
commented
Jan 5, 2023
| selectedPrompt := allPrompts[0][prompt].(map[string]interface{}) | ||
|
|
||
| return selectedPrompt | ||
| for _, value := range allPrompts { |
There was a problem hiding this comment.
Now, we'll want to iterated through all the values to match the provided prompt type.
Closed
6 tasks
sergiught
approved these changes
Jan 9, 2023
Widcket
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
As reported by #515, #575, the command
auth0 branding texts update <PROMPT_TYPE>will always fail when the prompt type is notlogin. For example,auth0 branding texts update signupwould always fail.This failure is caused by faulty logic that doesn't adequate traverse a set of default values for the provide prompt type, but this is better illustrated in the diff below. Further, if the prompt type is not found in the set of default values, which could happen if the default values change or new prompt types are added, the editor will start with an empty object instead of panicking.
📚 References
Related Issues: #515, #575
🔬 Testing
Added two integration tests with fixtures to show that multiple prompt types work now.
📝 Checklist