Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to parse blocks without version headers #62

Closed
Willyham opened this issue Jul 21, 2023 · 4 comments · Fixed by #72
Closed

Unable to parse blocks without version headers #62

Willyham opened this issue Jul 21, 2023 · 4 comments · Fixed by #72

Comments

@Willyham
Copy link

Willyham commented Jul 21, 2023

The new block version parsing code assumes the existence of the Eth-Consensus-Version, which according to the spec is required. However, not all providers send this back (e.g. QuickNode). It would be nice to fall back to the previous behaviour of the partial unmarshalling to find the version if the header doesn't exist.

@Willyham Willyham changed the title Some providers don't respect version headers Unable to parse blocks without version headers Jul 21, 2023
@mcdee
Copy link
Contributor

mcdee commented Jul 22, 2023

I would consider this a bug with the providers, in that case. Is it possible to raise this as an issue with them?

Note that this code has not yet been tagged, and won't be until all of the main consensus clients support it (currently waiting on a release of prysm) so there is some time for them to address this.

@Willyham
Copy link
Author

Hey @mcdee, totally agree that it's a problem on their side, but it might be nice from a user perspective to consider falling back to an admittedly slower but also equally correct implementation. I will also raise the issue with anyone where I see it missing, though as it's totally opaque it's hard to tell if its the client or the provider stripping headers.

I do think that the code is tagged though! I noticed the issue when we upgraded to 0.18.0 https://github.com/attestantio/go-eth2-client/blob/v0.18.0/http/http.go#L272

@mcdee
Copy link
Contributor

mcdee commented Jul 22, 2023

I'd really rather not have workarounds for implementation bugs, they tend to hang around in the code long after they are required.

The 0.18 tag wasn't meant to include the SSZ changes, sorry about that. Feel free to use 0.17 until they address this issue.

@mcdee
Copy link
Contributor

mcdee commented Aug 22, 2023

This issue has shown up in other situations so will address it.

mcdee added a commit that referenced this issue Aug 22, 2023
@mcdee mcdee closed this as completed in #72 Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants