Handling early <body> changes #1754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexreardon
commented
Feb 20, 2020
| // Remove from body | ||
| getBodyElement().removeChild(el); | ||
| // checking if element exists as the body might have been changed by thinks like 'turbolinks' | ||
| const body: HTMLBodyElement = getBodyElement(); |
There was a problem hiding this comment.
I found another culprit
There was a problem hiding this comment.
May want to change to things instead of thinks in the comment :)
| @@ -59,26 +59,6 @@ it('should remove the element when unmounting after a timeout', () => { | |||
| expect(getElement('5')).not.toBeTruthy(); | |||
| }); | |||
|
|
|||
| it('should not remove the element when unmounting after a timeout if the element does not exist', () => { | |||
There was a problem hiding this comment.
I removed this test in favour of one that catches any issues for all the components
sdb1228
reviewed
Feb 20, 2020
| if (getBodyElement().contains(el)) { | ||
| // not clearing the ref as it might have been set by a new effect | ||
| getBodyElement().removeChild(el); | ||
| // checking if element exists as the body might have been changed by thinks like 'turbolinks' |
There was a problem hiding this comment.
I think you mean things not thinks here :)
There was a problem hiding this comment.
thanks! changed
sdb1228
reviewed
Feb 20, 2020
| }); | ||
|
|
||
| forEachSensor((control: Control) => { | ||
| it('should have any errors when body is changed just before unmount: mid drag', () => { |
There was a problem hiding this comment.
💯 to this test. Much better sorry I should have probably just migrated it here :)
There was a problem hiding this comment.
All good! I wanted to get yours in and see if i could make it catch every component
sdb1228
approved these changes
Feb 20, 2020
alexreardon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #1751
Adding a test to catch any errors caused by the body changing just before an unmount
/cc @sdb1228