Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Migrate to DTO from AsyncApi.Net #188

Open
2 tasks done
yurvon-screamo opened this issue Mar 8, 2024 · 7 comments
Open
2 tasks done

[FEATURE] Migrate to DTO from AsyncApi.Net #188

yurvon-screamo opened this issue Mar 8, 2024 · 7 comments
Assignees

Comments

@yurvon-screamo
Copy link
Collaborator

Why do we need this improvement?

Reducing the complexity of the project and the cost of supporting the scheme

How will this change help?

We will use ready-made data schemas and greatly reduce the cost of supporting new versions of asyncapi

Screenshots

No response

How could it be implemented/designed?

  1. Remove the schema definition from the project.
  2. Transfer serializers to AsyncAPI.NET
  3. Adapt the functionality of the document name to the new schemes

https://github.com/LEGO/AsyncAPI.NET/

🚧 Breaking changes

No

👀 Have you checked for similar open issues?

  • I checked and didn't find a similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue?

Yes I am willing to submit a PR!

@VisualBean VisualBean self-assigned this Apr 22, 2024
@yurvon-screamo
Copy link
Collaborator Author

Hi, @VisualBean. I continue to actively implement the AsyncApi at work, we need version 3 of the specification, how are things going with this in LEGO now, should I start implementing here or wait and inject LEGO?

@VisualBean
Copy link
Collaborator

I'm currently working on implementing avro for message schemas,and then picking up 3.0 right after that. So hopefully won't take too long now.

@yurvon-screamo
Copy link
Collaborator Author

I'm currently working on implementing avro for message schemas,and then picking up 3.0 right after that. So hopefully won't take too long now.

Can I help you?

@VisualBean
Copy link
Collaborator

If you make a branch and start migrating to asyncapi.net, the 3.0 will of course have breaking changes, but all of the reading and writing will mostly stay exactly the same. So it should be almost as simple as upgrading the NuGet once in saunter.
It would help a lot starting the implementation here along side me building 3.0 for aayncapi.net.

@yurvon-screamo
Copy link
Collaborator Author

If you make a branch and start migrating to asyncapi.net, the 3.0 will of course have breaking changes, but all of the reading and writing will mostly stay exactly the same. So it should be almost as simple as upgrading the NuGet once in saunter. It would help a lot starting the implementation here along side me building 3.0 for aayncapi.net.

Okay, I hope I'll be done by the end of the week.

@yurvon-screamo
Copy link
Collaborator Author

If you make a branch and start migrating to asyncapi.net, the 3.0 will of course have breaking changes, but all of the reading and writing will mostly stay exactly the same. So it should be almost as simple as upgrading the NuGet once in saunter. It would help a lot starting the implementation here along side me building 3.0 for aayncapi.net.

Hi, I'm stuck on creating an instance of AsyncApiSchema from a message type, do you have any ideas other than a manual map?)

@VisualBean
Copy link
Collaborator

Not completely sure what you mean; but essentially you would need a map (if you can't infer it some other way) if you point me at some code I might be able to help more as I need a bit more to go on to know exactly what you are looking for

@yurvon-screamo yurvon-screamo mentioned this issue Jul 8, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants