Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider upgrading the code to be supported by AsyncAPI Parser-JS v2 #46

Closed
smoya opened this issue Sep 7, 2023 · 4 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@smoya
Copy link
Member

smoya commented Sep 7, 2023

Reason/Context

Parser-JS 2.0 (released as rc at this moment) is a completely new parser, with a lot of changes. The bigger ones are:

  • Completely rewritten to TS.
  • Implements the new parser-api, in particular, the version found in this PR.
  • Uses Spectral as parser/linter with the AsyncAPI ruleset.
  • Lots of other improvements, especially around Developer Experience.

Considering that Spectral now validates the documents before parsing, we had to update the interface for Schema parsers to separate validation from parsing. This change also introduced better errors and the way we handle them. (see this issue and related).

Description

Note that Parser-JS v2 uses TypeScript so feel free to use it as well.

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@GreenRover
Copy link
Collaborator

parser-js 2.1.0 is already supported.
PR for integration in react component is open: asyncapi/asyncapi-react#758

Or do i miss something to do?

@GreenRover GreenRover self-assigned this Sep 7, 2023
@smoya
Copy link
Member Author

smoya commented Sep 7, 2023

Yeah, I just was moving the issue from GreenRover/proto-schema-parser#2 to here without even checking. Can be closed.

@smoya smoya closed this as completed Sep 7, 2023
@smoya
Copy link
Member Author

smoya commented Sep 7, 2023

@GreenRover I created two crucial issues I consider should be done asap if we want to let people adopt the new protobuf schema format:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants