Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generator fails to run #498

Closed
thosaa opened this issue Feb 5, 2021 · 15 comments · Fixed by #499
Closed

generator fails to run #498

thosaa opened this issue Feb 5, 2021 · 15 comments · Fixed by #499
Labels
bug Something isn't working released

Comments

@thosaa
Copy link

thosaa commented Feb 5, 2021

Describe the bug

Our pipeline ran asynapi-generator fine on th 3rd feburary and now it does not.
I've checked it out locally and I get the same result.

Am I during something obviusly wrong?

Calling ag results in:

.\node_modules\.bin\ag -V
internal/modules/cjs/loader.js:329
      throw err;
      ^

Error: Cannot find module 'C:\...\node_modules\@asyncapi\generator-react-sdk\lib\index.js'. Please verify that the package.json has a valid "main" entry
    at tryPackage (internal/modules/cjs/loader.js:321:19)
    at Function.Module._findPath (internal/modules/cjs/loader.js:682:18)
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:952:27)
    at Function.Module._load (internal/modules/cjs/loader.js:841:27)
    at Module.require (internal/modules/cjs/loader.js:1025:19)
    at require (internal/modules/cjs/helpers.js:72:18)
    at Object.<anonymous> (C:\...\node_modules\@asyncapi\generator\lib\renderer\react.js:2:23)
    at Module._compile (internal/modules/cjs/loader.js:1137:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1157:10)
    at Module.load (internal/modules/cjs/loader.js:985:32) {
  code: 'MODULE_NOT_FOUND',
  path: 'C:\\...\\node_modules\\@asyncapi\\generator-react-sdk\\package.json',
  requestPath: '@asyncapi/generator-react-sdk'
}

How to Reproduce

Installing latest version and run ag or asyncapi-generator

It does not need to be the latest version as it seems to be a dependency which fails.

rm node_modeles
cat package.json:

{
  "name": "AsyncAPI-generator",
  "version": "0.0.0",
  "devDependencies": {
    "@asyncapi/generator": "1.1.6"
  }
}

npm install
.\node_modules.bin\ag

Expected behavior

The generator to run or ag -V to return the version.

Regards Thomas

@thosaa thosaa added the bug Something isn't working label Feb 5, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2021

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.

Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@derberg
Copy link
Member

derberg commented Feb 5, 2021

@thosaa interesting, latest release was bumped only because of the bump of the parser that had some minor fix in the JSON schema of the spec 🤔 and before that I was just fixing tests for windows https://github.com/asyncapi/generator/pull/496/files

@derberg
Copy link
Member

derberg commented Feb 5, 2021

oh damn, getting the same on mac 👀

@thosaa
Copy link
Author

thosaa commented Feb 5, 2021

@derberg Thanks for checking it out so fast. I'm glad to hear that I'm not the only one to see this.

@derberg
Copy link
Member

derberg commented Feb 5, 2021

@thosaa @bjoernmartin PR with fix opened. Once CI is ok and I get approval I will merge and the rest will be done automatically

@marcortw
Copy link
Contributor

marcortw commented Feb 5, 2021

Thanks @derberg for the quick fix! Just ran into the same issue

@derberg
Copy link
Member

derberg commented Feb 5, 2021

@marcortw sorry to hear

@derberg
Copy link
Member

derberg commented Feb 5, 2021

generator-react-sdk is already released with a fix, soon it will be updated in the generator by a bot

@derberg
Copy link
Member

derberg commented Feb 5, 2021

gimme some time to get it into the generator, our bot that was supposed to do it is already having 🍺 with other bots. Typical Friday

@marcortw
Copy link
Contributor

marcortw commented Feb 5, 2021

That 🚀 was meant more like "wow, you're fast" and thanking you for your effort 👍

@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 1.1.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@derberg
Copy link
Member

derberg commented Feb 5, 2021

@thosaa @bjoernmartin @marcortw lemme know if 1.1.7 is ok
on my side all looks good

@thosaa
Copy link
Author

thosaa commented Feb 5, 2021

@derberg All good again. 👍 Thanks

@marcortw
Copy link
Contributor

marcortw commented Feb 6, 2021

Same here, it works. Thanks again!

@bjoernmartin
Copy link

Yep, all back to normal. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants