fix: use production version of react/jsx-runtime

[magicmatatjahu]

Description

Use production version of react/jsx-runtime to disable development warnings and also speed up the code. Change the react/jsx-runtime import to react/cjs/react-jsx-runtime.production.min in transpiled bundle.

How to test (in easiest way):

• link or install locally this package from my PR in @asyncapi/generator package
• test @asyncapi/markdown-template template and you shouldn't see any warnings related to key props.

Related issue(s)
Resolves #37

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[jonaslagoni]

👍

[magicmatatjahu]

@jonaslagoni You had right (in one of the issue comments) with production version of react :) Thanks!

[jonaslagoni]

@jonaslagoni You had right (in one of the issue comments) with production version of react :) Thanks!

@magicmatatjahu would there be any use-case where we would not want to use the production version? 🤔

Thinking about in development, anything production lib makes difficult?

[magicmatatjahu]

@magicmatatjahu would there be any use-case where we would not want to use the production version? 🤔

Thinking about in development, anything production lib makes difficult?

I thought about that, but react only make warns for internal props like key which for us isn't needed and ref which doesn't work properly due to fact that we don't handle dynamic component, but only render component to string, so this prop is unnecessary.

[magicmatatjahu]

@jonaslagoni We can make two separate compilation process for dev and prod and integrate it with generator with flag --compile=prod|dev, but only when community will raise that issue :)

[jonaslagoni]

@jonaslagoni We can make two separate compilation process for dev and prod and integrate it with generator with flag --compile=prod|dev, but only when community will raise that issue :)

As long as adding this production dependency does not suddenly hide warnings and problems that make the development of templates harder we should be good 👍

[magicmatatjahu]

The warnings will be hidden, but they don't matter to us because they are used only for dynamic components that may change in runtime, eg in html app :) I also checked the markdown-template by adding a few bug and we have an error trace due to the source-map, so it's not bad :) Errors will still appear from jsx-runtime but we only hide warnings :)

[asyncapi-bot]

🎉 This PR is included in version 0.2.9 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀