Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reimport file on each render #12

Merged

Conversation

magicmatatjahu
Copy link
Member

@magicmatatjahu magicmatatjahu commented Jan 5, 2021

Description

We have a bug inside the SDK. If we turn generator in --watch-template mode then with current implementation React-SDK render imported template file (component) from cache. This PR fixes it.

Related issue(s)
Part of asyncapi/generator#465

@magicmatatjahu magicmatatjahu added the bug Something isn't working label Jan 5, 2021
src/renderer/template.ts Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jan 5, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need a bit of clarification

src/renderer/template.ts Show resolved Hide resolved
src/renderer/template.ts Show resolved Hide resolved
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@magicmatatjahu magicmatatjahu merged commit 6c38f8e into asyncapi:master Jan 7, 2021
@magicmatatjahu magicmatatjahu deleted the refresh-state-in-import branch January 7, 2021 11:00
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants