Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ui enhancement for the sub components of venue #367

Closed

Conversation

chaitanyakatore
Copy link

Description

  • added the border and underline design for the sub components of venue
  • did changes for both mobile and desktop devices
  • added map icon for better understanding of component
Screenshot 2024-08-25 at 12 22 36 AM Screenshot 2024-08-25 at 12 21 16 AM

Related issue(s)

fixes the issue : #366

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

netlify bot commented Aug 24, 2024

Deploy Preview for peaceful-ramanujan-288045 ready!

Name Link
🔨 Latest commit f781703
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/66ca34e6ffe28e0008e3f73e
😎 Deploy Preview https://deploy-preview-367--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@chaitanyakatore chaitanyakatore changed the title feat: UI enhancement for the Sub components of Venue feat: ui enhancement for the sub components of venue Aug 24, 2024
@chaitanyakatore
Copy link
Author

@Mayaleeeee
@thulieblack
@AceTheCreator
any suggestions ?

@AceTheCreator
Copy link
Member

Hey @chaitanyakatore, thanks for such an awesome contribution but unfortunately I think these changes are not needed at the moment.

Please feel free to suggest other improvements or help pick up and fix existing issues.

I'm gonna have to close this PR.

Looking forward to see another PR from you ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants