Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] <In the Dropdown section, contents are not perfectly aligned in the mobile view> #345

Open
2 tasks done
souvikjs01 opened this issue Jul 12, 2024 · 16 comments · May be fixed by #347 or #360
Open
2 tasks done

[BUG] <In the Dropdown section, contents are not perfectly aligned in the mobile view> #345

souvikjs01 opened this issue Jul 12, 2024 · 16 comments · May be fixed by #347 or #360
Labels
bug Something isn't working

Comments

@souvikjs01
Copy link

Describe the bug.

Dropdown icon does not showing, and 'All' is aligned in left side.

Expected behavior

Dropdown icon should be shown, and the inner content of the button should be in the middle.

Screenshots

asyncapi

How to Reproduce

  1. I first did this
  2. I then did this
  3. And so on . . .

🥦 Browser

Google Chrome

👀 Have you checked for similar open issues?

  • I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue ?

Yes I am willing to submit a PR!

@souvikjs01 souvikjs01 added the bug Something isn't working label Jul 12, 2024
Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@ashmit-coder
Copy link
Contributor

Hey @Mayaleeeee could provide some insight on weather it's a bug or design decision?

@souvikjs01
Copy link
Author

Actually, there is code conflicting in Dropdown component, which has written justify-center and at the same time justify-between, so do you want these elements to be in the center or both end according to your design?

@Mayaleeeee
Copy link
Member

Mayaleeeee commented Jul 12, 2024

Hey @Mayaleeeee could provide some insight on weather it's a bug or design decision?

Thanks for the ping @ashmit-coder

I'm still trying to understand what the issue is l @souvikjs01 because it's working perfectly here from my side.

Please listen to the recording below.

XRecorder_Compressed_12072024_144645.mp4

Also, @ashmit-coder, we should change the colour of the drop-down icon, I can barely see it.

@souvikjs01
Copy link
Author

Hey @Mayaleeeee
I did not notice the dropdown icon, the bg color are same, so i thought it should be in the center like the picture.
Also "justify-center" that create confusion this to be in center.

as

@anuragnegi000
Copy link

is this issue is already completed? if not please assign it to me

@AceTheCreator
Copy link
Member

@Mayaleeeee @souvikjs01 @ashmit-coder, what's the status of this discussion?

@ashmit-coder
Copy link
Contributor

Hey @Mayaleeeee could provide some insight on weather it's a bug or design decision?

Thanks for the ping @ashmit-coder

I'm still trying to understand what the issue is l @souvikjs01 because it's working perfectly here from my side.

Please listen to the recording below.

XRecorder_Compressed_12072024_144645.mp4
Also, @ashmit-coder, we should change the colour of the drop-down icon, I can barely see it.

Hey @Mayaleeeee sorry for the late reply.

The colour feature is a good, point and I think this issue should resolve that.

About the back feature that you suggested, I dont think thats how we should approach it, we can discuss that in another issue in my opinion.

@ashmit-coder
Copy link
Contributor

Hey @Mayaleeeee I did not notice the dropdown icon, the bg color are same, so i thought it should be in the center like the picture. Also "justify-center" that create confusion this to be in center.

as

Hey @Mayaleeeee do you think we should do this?

@Mayaleeeee
Copy link
Member

Hey @Mayaleeeee I did not notice the dropdown icon, the bg color are same, so i thought it should be in the center like the picture. Also "justify-center" that create confusion this to be in center.

as

Hey @Mayaleeeee do you think we should do this?

Hello @ashmit-coder , the screenshot below was the response I got when I tried viewing the image you attached to this message.

Screenshot_20240808_213746_Samsung Internet.jpg

@ashmit-coder
Copy link
Contributor

Hey @Mayaleeeee I did not notice the dropdown icon, the bg color are same, so i thought it should be in the center like the picture. Also "justify-center" that create confusion this to be in center.

as

Hey @Mayaleeeee do you think we should do this?

Hello @ashmit-coder , the screenshot below was the response I got when I tried viewing the image you attached to this message.

Screenshot_20240808_213746_Samsung Internet.jpg

Is this visible?
[Screenshot_20240809_102154_GitHub.jpg

@Mayaleeeee
Copy link
Member

Mayaleeeee commented Aug 21, 2024

Hey @Mayaleeeee I did not notice the dropdown icon, the bg color are same, so i thought it should be in the center like the picture. Also "justify-center" that create confusion this to be in center.
as

Hey @Mayaleeeee do you think we should do this?

Hello @ashmit-coder , the screenshot below was the response I got when I tried viewing the image you attached to this message.
Screenshot_20240808_213746_Samsung Internet.jpg

Is this visible? [Screenshot_20240809_102154_GitHub.jpg

Do you mean the icon? @ashmit-coder

@ashmit-coder
Copy link
Contributor

Hey @Mayaleeeee I did not notice the dropdown icon, the bg color are same, so i thought it should be in the center like the picture. Also "justify-center" that create confusion this to be in center.
as

Hey @Mayaleeeee do you think we should do this?

Hello @ashmit-coder , the screenshot below was the response I got when I tried viewing the image you attached to this message.
Screenshot_20240808_213746_Samsung Internet.jpg

Is this visible? [Screenshot_20240809_102154_GitHub.jpg

Do you mean the icon? @ashmit-coder

No the text in the buttons. Shall we make it center aligned rather than the existing left aligned

@Mayaleeeee
Copy link
Member

Hey @Mayaleeeee I did not notice the dropdown icon, the bg color are same, so i thought it should be in the center like the picture. Also "justify-center" that create confusion this to be in center.
as

Hey @Mayaleeeee do you think we should do this?

Hello @ashmit-coder , the screenshot below was the response I got when I tried viewing the image you attached to this message.
Screenshot_20240808_213746_Samsung Internet.jpg

Is this visible? [Screenshot_20240809_102154_GitHub.jpg

Do you mean the icon? @ashmit-coder

No the text in the buttons. Shall we make it center aligned rather than the existing left aligned

Yes, please.

The centre looks good. @ashmit-coder

@souvikjs01
Copy link
Author

@ashmit-coder @Mayaleeeee
Can I work on it?? If so, please assign it to me.

@ashmit-coder
Copy link
Contributor

@ashmit-coder @Mayaleeeee
Can I work on it?? If so, please assign it to me.

You can start working no need to be assigned!

@souvikjs01 souvikjs01 linked a pull request Aug 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
5 participants