-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added prettier and formatted the files #332
Conversation
✅ Deploy Preview for peaceful-ramanujan-288045 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey @thulieblack @AceTheCreator if these changes look good I will add the github workflow as well! |
@ashmit-coder, all of these changes are made by the prettier script, right? |
yes, in addition to adding the command for prettier in the package.json |
Hey @AceTheCreator do take a look I have added the workflow as well. :) |
I checked the file, and it looks pretty good. Did you test it? |
Yeah I did test it with act |
… into feat/add-prettier
@ashmit-coder can you please resolve the conflict in this pr ? |
… into feat/add-prettier
@AceTheCreator done |
/ptal |
@thulieblack @Mayaleeeee Please take a look at this PR. Thanks! 👋 |
@ashmit-coder sorry i missed your reminder, can you resolve the current conflict too 🙏🏾 |
… into feat/add-prettier
Hey @AceTheCreator done |
I noticed in your changes that it seems prettier ran on the .github directory too. should we allow such? |
I mean thats your call, but i guess newly added scripts should also be formatted. If you want I will revert those changes and limit it to not enter .github |
I guess you're right in terms of new scripts. |
Hi @ashmit-coder @AceTheCreator 👋 I noticed that the It may become a hassle in the future with repeated formatting whenever a someone uses the I would suggest to exclude the |
Hey @AceTheCreator I will close this Pr and add prettier to the |
@AnimeshKumar923 your views will be really helpfull here |
I'll take a look at it. @ashmit-coder 👍 |
Description
Related issue(s)
Resolves: #331