✅ Deploy Preview for peaceful-ramanujan-288045 ready!

Name	Link
🔨 Latest commit	0a1efc7
🔍 Latest deploy log	https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/668bddbfe2771300089b7d76
😎 Deploy Preview	https://deploy-preview-332--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Hey @thulieblack @AceTheCreator if these changes look good I will add the github workflow as well!

@ashmit-coder, all of these changes are made by the prettier script, right?

@ashmit-coder, all of these changes are made by the prettier script, right?

yes, in addition to adding the command for prettier in the package.json

Hey @AceTheCreator do take a look I have added the workflow as well. :)

Hey @AceTheCreator do take a look I have added the workflow as well. :)

I checked the file, and it looks pretty good. Did you test it?

Hey @AceTheCreator do take a look I have added the workflow as well. :)

I checked the file, and it looks pretty good. Did you test it?

Yeah I did test it with act

@ashmit-coder can you please resolve the conflict in this pr ?

@AceTheCreator done

/ptal

@thulieblack @Mayaleeeee Please take a look at this PR. Thanks! 👋

@ashmit-coder sorry i missed your reminder, can you resolve the current conflict too 🙏🏾

Hey @AceTheCreator done

Hey @AceTheCreator done

I noticed in your changes that it seems prettier ran on the .github directory too. should we allow such?

Hey @AceTheCreator done

I noticed in your changes that it seems prettier ran on the .github directory too. should we allow such?

I mean thats your call, but i guess newly added scripts should also be formatted. If you want I will revert those changes and limit it to not enter .github

Hey @AceTheCreator done

I noticed in your changes that it seems prettier ran on the .github directory too. should we allow such?

I mean thats your call, but i guess newly added scripts should also be formatted. If you want I will revert those changes and limit it to not enter .github

I guess you're right in terms of new scripts.

Hi @ashmit-coder @AceTheCreator 👋

I noticed that the .github directory is also being affected by it. It is centrally managed from https://github.com/asyncapi/.github
Whenever there is a change in the central repository, the whole .github file is pulled and replicated across every repository under AsyncAPI. When that happens it would revert these changes because there is no prettier formatting in that repository.

It may become a hassle in the future with repeated formatting whenever a someone uses the prettier extension and may create confusion.

I would suggest to exclude the .github repo from the prettier linting.

Hey @AceTheCreator I will close this Pr and add prettier to the Next Lint PR Cause version control is giving a lot of issues while changing the .github folder

@AnimeshKumar923 your views will be really helpfull here
#307

@AnimeshKumar923 your views will be really helpfull here #307

I'll take a look at it. @ashmit-coder 👍