Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add next lint and prettier workflow #307

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

ashmit-coder
Copy link
Contributor

@ashmit-coder ashmit-coder commented Apr 10, 2024

Description

  • .Added a github workflow to check for next linting issues

Related issue(s)

Resolves: #306 , #331

Copy link

netlify bot commented Apr 10, 2024

Deploy Preview for peaceful-ramanujan-288045 ready!

Name Link
🔨 Latest commit 21234fe
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/6698bb9973bfbc00083b93d6
😎 Deploy Preview https://deploy-preview-307--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ashmit-coder
Copy link
Contributor Author

ashmit-coder commented Apr 10, 2024

Hey @AceTheCreator am looking forward to solving the existing next warning with this as well but they will require some time.
Meanwhile can you just check on this workflow and see if it is upto the mark :)

@AceTheCreator
Copy link
Member

@ashmit-coder can you share a screenshot of your PR fixing the issue?

@ashmit-coder
Copy link
Contributor Author

@ashmit-coder can you share a screenshot of your PR fixing the issue?

Actually am still working on fixing the exisiting lint errors. I might need some more time, due to my semester ending soon, I have a lot of academic work.

If anyone else can help with that it will be great.

@AceTheCreator
Copy link
Member

@ashmit-coder can you share a screenshot of your PR fixing the issue?

Actually am still working on fixing the exisiting lint errors. I might need some more time, due to my semester ending soon, I have a lot of academic work.

If anyone else can help with that it will be great.

Take your time @ashmit-coder 🙏🏾

@ashmit-coder
Copy link
Contributor Author

I will update this when after the prettier PR is merged

Copy link

@AnimeshKumar923 AnimeshKumar923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a review from my side, have a look at it and let me know your thoughts on this @ashmit-coder

.github/workflows/next-lint-check.yml Outdated Show resolved Hide resolved
.github/workflows/next-lint-check.yml Show resolved Hide resolved
.github/workflows/next-lint-check.yml Outdated Show resolved Hide resolved
.github/workflows/next-lint-check.yml Outdated Show resolved Hide resolved
.github/workflows/next-lint-check.yml Outdated Show resolved Hide resolved
.github/workflows/next-lint-check.yml Outdated Show resolved Hide resolved
@ashmit-coder ashmit-coder changed the title ci: add next lint workflow ci: add next lint and prettier workflow Jul 18, 2024
@ashmit-coder
Copy link
Contributor Author

hey @AnimeshKumar923 and @AceTheCreator here are the changes.

Copy link

@AnimeshKumar923 AnimeshKumar923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAML file LGTM! 🚀

@AnimeshKumar923
Copy link

I've reviewed the YAML file as per my knowledge. For rest of the files, I'm not well-versed as of now. @AceTheCreator PTAL at the remaining files.

@ashmit-coder
Copy link
Contributor Author

Hey @AceTheCreator @AnimeshKumar923 , we will have to put this pr on hold, I have seen issues due to recent commits in the repo and these lints are bound to fail if merged, so in my opinion lets keep it on hold just and hopefully merge it during the addition of cypress tests to the site!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add next lint tests
4 participants