-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add next lint and prettier workflow #307
base: master
Are you sure you want to change the base?
ci: add next lint and prettier workflow #307
Conversation
✅ Deploy Preview for peaceful-ramanujan-288045 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey @AceTheCreator am looking forward to solving the existing next warning with this as well but they will require some time. |
@ashmit-coder can you share a screenshot of your PR fixing the issue? |
Actually am still working on fixing the exisiting lint errors. I might need some more time, due to my semester ending soon, I have a lot of academic work. If anyone else can help with that it will be great. |
Take your time @ashmit-coder 🙏🏾 |
I will update this when after the prettier PR is merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a review from my side, have a look at it and let me know your thoughts on this @ashmit-coder
… into feat/add-next-lint-check
…coder/conference-website into feat/add-next-lint-check
hey @AnimeshKumar923 and @AceTheCreator here are the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YAML file LGTM! 🚀
I've reviewed the YAML file as per my knowledge. For rest of the files, I'm not well-versed as of now. @AceTheCreator PTAL at the remaining files. |
Hey @AceTheCreator @AnimeshKumar923 , we will have to put this pr on hold, I have seen issues due to recent commits in the repo and these lints are bound to fail if merged, so in my opinion lets keep it on hold just and hopefully merge it during the addition of cypress tests to the site! |
Description
Related issue(s)
Resolves: #306 , #331