Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

would be nice if venue from past events is grayed out #208

Closed
derberg opened this issue Oct 2, 2023 · 18 comments · May be fixed by #289
Closed

would be nice if venue from past events is grayed out #208

derberg opened this issue Oct 2, 2023 · 18 comments · May be fixed by #289
Labels
area/javascript enhancement New feature or request good first issue Good for newcomers Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com stale

Comments

@derberg
Copy link
Member

derberg commented Oct 2, 2023

When you go to conference.asyncapi.com you see Venues section

I think that it would be nice if for past events, given venue is somehow grayed out, or have some water mark like ended 🤔

@Mayaleeeee wdyt? how that should be done? just grayed out?

@derberg derberg added the enhancement New feature or request label Oct 2, 2023
@Mayaleeeee
Copy link
Member

Thank you, Lukasz. I appreciate your input.

Here's what I think;

  1. I agree that reducing the opacity by greying it out would be a good idea. Additionally, we could include the text "Ended or Completed" beside the date in the venue section and the venue page before the location's name. I have attached some images for your reference. Please take a look and let me know your thoughts.

Beside the date
Screenshot 2023-10-02 121928

Before the name
Screenshot 2023-10-02 122031

  1. We could have a new "Upcoming Events" and "Past Events" section before the speakers' section, with a layout as shown in the reference image.
    WhatsApp Image 2023-10-02 at 12 34 35 PM

Copy link
Member Author

derberg commented Oct 2, 2023

We could have a new "Upcoming Events" and "Past Events" section before the speakers' section, with a layout as shown in the reference image.

sounds good, but I guess it is a separate issue?

@Mayaleeeee
Copy link
Member

We could have a new "Upcoming Events" and "Past Events" section before the speakers' section, with a layout as shown in the reference image.

sounds good, but I guess it is a separate issue?

Yes.

@derberg
Copy link
Member Author

derberg commented Oct 3, 2023

@Mayaleeeee I will mark this issue as /gfi js
and put it up for hacktoberfest and point 1 is defined. For the other great idea please open a separate issue.

@derberg derberg added the Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com label Oct 3, 2023
@asyncapi-bot
Copy link
Contributor

Hey @derberg, your message doesn't follow the requirements, you can try /help.

@derberg
Copy link
Member Author

derberg commented Oct 3, 2023

/gfi js

@Mayaleeeee
Copy link
Member

@Mayaleeeee I will mark this issue as /gfi js and put it up for hacktoberfest and point 1 is defined. For the other great idea please open a separate issue.

Alright, I will.
Thank you.

@Arbtrage
Copy link

Arbtrage commented Oct 6, 2023

Hey @derberg, I would like to work on this issue.

Copy link
Member Author

derberg commented Oct 7, 2023

go ahead 🙏

@Arbtrage
Copy link

Arbtrage commented Oct 8, 2023

Hi @derberg , I saw that in the date field there was no particular format follow. I was thinking of using Date module to compare the dates, but found dissimilar date formats. Like in one event there is a range and others have a single date.
I am a bit confused as to how to approach this new format. Can you provide some suggestions ?

For example,
London: ""September 20, 2023""
Paris: "December 6-8, 2023"

Should I use regex expression for this or traverse the string to look for range format ?

Copy link
Member Author

derberg commented Oct 9, 2023

hey, not a codeowner here

@AceTheCreator please have a look

@Arbtrage
Copy link

I have added a tag Ended after the date for the events that are already over.
I figured that there can be two types of events:

  • Single day
  • 2 or more days

I created a function where it would hadle these two cases and return whether the event has passed or not. According to that returned value the Ended tag is being added.

Let me know if I need to make some UI changes or apply another Logic.

@AceTheCreator @derberg

image

Copy link

github-actions bot commented Feb 9, 2024

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Feb 9, 2024
@Mayaleeeee
Copy link
Member

Still relevant

@github-actions github-actions bot removed the stale label Feb 23, 2024
@IAmRiteshKoushik
Copy link

Hey, I would like to work on this issue. May I have is assigned to me ?

@monoMonu
Copy link

@AceTheCreator @Mayaleeeee

I have made the required changes and added a function, which compares the present date and event date to decide the tag for the event (from Upcoming and Ended). Also fades the text color of past events. This is specific to the current format of date used in the cityList.json file.
I tested the code by changing the date of one of the events as you can see...because there were only upcoming events.

I have also removed the "apply to be a speaker" button from the past events as it has no use there.

Please review the PR and if there is any other changes needed, then please let me know

@Mayaleeeee
Copy link
Member

@AceTheCreator @Mayaleeeee

I have made the required changes and added a function, which compares the present date and event date to decide the tag for the event (from Upcoming and Ended). Also fades the text color of past events. This is specific to the current format of date used in the cityList.json file. I tested the code by changing the date of one of the events as you can see...because there were only upcoming events.

I have also removed the "apply to be a speaker" button from the past events as it has no use there.

Please review the PR and if there is any other changes needed, then please let me know

I have just left a comment on the PR. Thank you.

Copy link

github-actions bot commented Aug 7, 2024

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/javascript enhancement New feature or request good first issue Good for newcomers Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants