Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As A user, the CI should prevent me schedule an adhoc meeting in the past #746

Closed
Amzani opened this issue Jun 9, 2023 · 3 comments · Fixed by #751
Closed

As A user, the CI should prevent me schedule an adhoc meeting in the past #746

Amzani opened this issue Jun 9, 2023 · 3 comments · Fixed by #751
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Amzani
Copy link
Contributor

Amzani commented Jun 9, 2023

Describe the bug

When scheduling an adhoc meeting, the CI should fail if the event is in the past

How to Reproduce

Go to https://github.com/asyncapi/community/actions/workflows/create-event-ad-hoc.yml
Schedule an event in the past
Screenshot 2023-06-09 at 13 01 50

Expected behavior

CI should fail with an invalid input and a clear error message mentioning that the input date is in the past.
@Amzani Amzani added bug Something isn't working good first issue Good for newcomers labels Jun 9, 2023
@manulpatel
Copy link

Hello @Amzani! I am new to AsyncAPI and would like to work on this. I think we need to put a validation check with current time and date. Could you please give any hints?

@Amzani
Copy link
Contributor Author

Amzani commented Jun 16, 2023 •
edited
Loading

Hi @manulpatel , you're right, please go ahead

@princerajpoot20 princerajpoot20 mentioned this issue Jun 16, 2023
Merged
@princerajpoot20
Copy link
Member

@Amzani Could you please review this PR #751.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add validation step to check if the event date is in the future. princerajpoot20/community
3 participants
@Amzani @princerajpoot20 @manulpatel